Skip to content

Conversation

@narfdre
Copy link
Collaborator

@narfdre narfdre commented Jul 5, 2025

Screenshot 2025-07-05 at 5 12 18 PM

Copy link
Member

@rphovley rphovley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you so much!

Just move the aggregation code into the service module MonitorApi and we'll be golden

>
<Link to="/categories">
<ChartIcon size={20} />
{hasPendingInvitesReceived && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy pasta?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird merging conflicts actually 😮‍💨. I'll get it cleaned up

total: number,
}> = {}

summary.appUsage.forEach(app => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pull the aggregation code up into the MonitorApi for now.

I think we may end up extending the getTimeCreatingByHour and adding the tag "type" as a param. It rolls up the time into hour blocks in a similar way. Right now it just uses the "default" tag type but I think we should be able to make that dynamic to the tag type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about doing that extension. I can take care of that when i get around to it

@rphovley rphovley merged commit af1b2a1 into main Jul 13, 2025
1 check passed
@rphovley rphovley deleted the apk/category-view branch July 19, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants