Skip to content

Implement parse and compare hooks #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
olmokramer wants to merge 78 commits into
base: develop
Choose a base branch
from
Draft

Implement parse and compare hooks #16

olmokramer wants to merge 78 commits into from

Conversation

@olmokramer
Copy link

@olmokramer olmokramer commented Sep 8, 2023

This adds 4 lifecycle hooks:

  • A pre-parsing stage hook, which is called before all submissions are parsed. It is called with the list with all submission paths eligible for the comparison, i.e. all paths that are not filtered out by SubmissionSetBuilder.isExcludedEntry.
  • A post-parsing hook per submission, which is called after the submission has been parsed. It is called with the Submission object that has been parsed.
  • A pre-comparing stage hook, which is called before the comparisons are started. It is called with a list of all comparison tuples.
  • A post-comparing hook, which is called after each comparison. It is called with the SubmissionTuple that has just been compared.

Kr0nox and others added 23 commits July 28, 2023 14:47
@olmokramer olmokramer force-pushed the feature/add-parse-and-compare-hooks branch 3 times, most recently from 48ecef4 to b72c61f Compare September 8, 2023 14:24
@olmokramer olmokramer force-pushed the feature/add-parse-and-compare-hooks branch from 0be6f36 to c8b2379 Compare September 18, 2023 14:39
Kr0nox and others added 25 commits September 18, 2023 17:44
@Kr0nox
Merge remote-tracking branch 'origin/develop' into report-viewer/stor…
a378218 
…e-metric
@Kr0nox
remove log message
abfe349
@sebinside
Merge pull request jplag#1290 from jplag/report-viewer/store-metric
10adb0d 
Store selections from overview when switching views
@dependabot
Dependency(deps-dev): Bump @playwright/test from 1.37.1 to 1.38.0 in …
482ad43 
…/report-viewer (jplag#1306)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependency(deps-dev): Bump postcss from 8.4.29 to 8.4.30 in /report-v…
1b64236 
…iewer (jplag#1304)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependency(deps-dev): Bump @types/jsdom from 21.1.2 to 21.1.3 in /rep…
1e4a5bf 
…ort-viewer (jplag#1305)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependency(deps-dev): Bump @rushstack/eslint-patch from 1.3.3 to 1.4.…
fdbeec7 
…0 in /report-viewer (jplag#1308)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @tsaglam
Dependency(deps): Bump org.eclipse.emf:org.eclipse.emf.ecore
c222524 
Bumps [org.eclipse.emf:org.eclipse.emf.ecore](https://github.com/eclipse-emf/org.eclipse.emf) from 2.34.0 to 2.35.0.
- [Commits](https://github.com/eclipse-emf/org.eclipse.emf/commits)

---
updated-dependencies:
- dependency-name: org.eclipse.emf:org.eclipse.emf.ecore
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @tsaglam
Dependency(deps): Bump org.eclipse.emf:org.eclipse.emf.ecore.xmi
2c98dcc 
Bumps [org.eclipse.emf:org.eclipse.emf.ecore.xmi](https://github.com/eclipse-emf/org.eclipse.emf) from 2.18.0 to 2.35.0.
- [Commits](https://github.com/eclipse-emf/org.eclipse.emf/commits)

---
updated-dependencies:
- dependency-name: org.eclipse.emf:org.eclipse.emf.ecore.xmi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @tsaglam
Dependency(deps): Bump org.eclipse.emf:org.eclipse.emf.common
8ef14dd 
Bumps [org.eclipse.emf:org.eclipse.emf.common](https://github.com/eclipse-emf/org.eclipse.emf) from 2.28.0 to 2.29.0.
- [Commits](https://github.com/eclipse-emf/org.eclipse.emf/commits)

---
updated-dependencies:
- dependency-name: org.eclipse.emf:org.eclipse.emf.common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@tsaglam
Merge pull request jplag#1263 from mbrdl/antlr-utils-rewrite
8abdb4c 
Re-write/Fix antlr-utils
@dependabot @tsaglam
Dependency(deps): Bump org.apache.maven.plugins:maven-javadoc-plugin
094fab8 
Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.5.0 to 3.6.0.
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.5.0...maven-javadoc-plugin-3.6.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@tsaglam
Merge pull request jplag#1301 from CodeGra-de/bugfix/allow-passing-mu…
7ca56ff 
…ltiple-advanced-args

Allow passing multiple options in the "Advanced" group
@dependabot
Dependency(deps-dev): Bump eslint from 8.49.0 to 8.50.0 in /report-vi…
77e22dd 
…ewer (jplag#1318)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependency(deps-dev): Bump @types/node from 18.17.17 to 18.18.0 in /r…
8f0f5f7 
…eport-viewer (jplag#1315)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependency(deps-dev): Bump @playwright/test from 1.38.0 to 1.38.1 in …
dd1a20d 
…/report-viewer (jplag#1314)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependency(deps): Bump vue-router from 4.2.4 to 4.2.5 in /report-view…
9b877a3 
…er (jplag#1316)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependency(deps): Bump edu.stanford.nlp:stanford-corenlp from 4.5.4 t…
7d1682e 
…o 4.5.5 (jplag#1313)

Bumps edu.stanford.nlp:stanford-corenlp from 4.5.4 to 4.5.5.

---
updated-dependencies:
- dependency-name: edu.stanford.nlp:stanford-corenlp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Dependency(deps): Bump org.scalameta:scalameta_2.13 from 4.8.10 to 4.…
8722f62 
…8.11 (jplag#1312)

Bumps [org.scalameta:scalameta_2.13](https://github.com/scalameta/scalameta) from 4.8.10 to 4.8.11.
- [Release notes](https://github.com/scalameta/scalameta/releases)
- [Commits](scalameta/scalameta@v4.8.10...v4.8.11)

---
updated-dependencies:
- dependency-name: org.scalameta:scalameta_2.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Kr0nox
add view wrapper for async views
953bdc9
@Kr0nox
bump vue-tsc to 1.8.15
afc3f82
@sebinside
Merge pull request jplag#1321 from jplag/report-viewer/bump-vue-tsc
94301a0 
Bump vue-tsc to 1.8.15
@sebinside
Merge pull request jplag#1320 from jplag/report-viewer/view-wrapper
9149f42 
Wrapper for async Views
@olmokramer
Add parse and compare hooks
a6f810b 
This adds 4 hooks that can be set on the `JPlagOptions` class:

- A pre-parsing stage hook, which is called before all submissions are
  parsed. It is called with the list with all submission paths eligible
  for the comparison, i.e. all paths that are not filtered out by
  `SubmissionSetBuilder.isExcludedEntry`.
- A post-parsing hook per submission, which is called after the
  submission has been parsed. It is called with the `Submission`
  object that has been parsed.
- A pre-comparing stage hook, which is called before the comparisons
  are started. It is called with a list of all comparison tuples.
- A post-comparing hook, which is called after each comparison. It
  is called with the `SubmissionTuple` that has just been compared.
@olmokramer
Add tests for the parse and compare hooks
55624bd
@olmokramer olmokramer force-pushed the feature/add-parse-and-compare-hooks branch from c8b2379 to 55624bd Compare October 3, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@olmokramer @Kr0nox @brodmo @sebinside @tsaglam @libre-man