Skip to content

Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 2 | Book-library #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fares-Bakhet wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 2 | Book-library #345

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f3bdb5
Finish Book-Library webpage
Fares-Bakhet Dec 7, 2025
0d9263a
Improving he Book Library app
Fares-Bakhet Dec 8, 2025
dbc998a
Fix HTML file
Fares-Bakhet Dec 16, 2025
615130e
Fix script.js file
Fares-Bakhet Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
139 changes: 50 additions & 89 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,57 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Library App</title>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" />
</head>
<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<button data-toggle="collapse" data-target="#formCollapse" class="btn btn-info">Add new book</button>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<div id="formCollapse" class="collapse mt-3">
<form id="bookForm" class="form-group">
<label for="titleInput">Title:</label>
<input id="titleInput" class="form-control" required />

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
</div>
<label for="authorInput">Author:</label>
<input id="authorInput" class="form-control" required />

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>
<label for="pagesInput">Pages:</label>
<input id="pagesInput" type="number" class="form-control" required />

<script src="script.js"></script>
</body>
<label class="form-check-label mt-2">
<input type="checkbox" class="form-check-input" id="readCheckbox" /> Read
</label>

<button type="submit" class="btn btn-primary mt-3">Submit</button>
</form>
</div>

<table class="table" id="displayTable">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Pages</th>
<th>Read</th>
<th>Action</th>
</tr>
</thead>
<tbody></tbody>
</table>


<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>


<script type="module" src="script.js"></script>
</body>
</html>
190 changes: 98 additions & 92 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,109 @@
let myLibrary = [];
class Book {
constructor(title, author, pages, read) {
this.title = title;
this.author = author;
this.pages = pages;
this.read = read;
}
}


const library = [
new Book("Robinson Crusoe", "Daniel Defoe", 252, true),
new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true),
];


const bookForm = document.getElementById("bookForm");
const titleInput = document.getElementById("titleInput");
const authorInput = document.getElementById("authorInput");
const pagesInput = document.getElementById("pagesInput");
const readCheckbox = document.getElementById("readCheckbox");
const tableBody = document.querySelector("#displayTable tbody");


bookForm.addEventListener("submit", (event) => {
event.preventDefault();

const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = Number(pagesInput.value);
const read = readCheckbox.checked;


if (!title || !author || !Number.isInteger(pages) || pages <= 0) {
alert("Please enter valid book details.");
return;
}


library.push(new Book(title, author, pages, read));


bookForm.reset();


window.addEventListener("load", function (e) {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}

function render() {

tableBody.innerHTML = "";

library.forEach((book, index) => {
const row = document.createElement("tr");

row.innerHTML = `
<td>${book.title}</td>
<td>${book.author}</td>
Copy link
Contributor

@cjyuan cjyuan Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you suggest an approach to combat special characters such as '<' and '&' that may exist in a book title? If these characters are not handled properly, they may ruin the display.

Copy link
Author

@Fares-Bakhet Fares-Bakhet Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjyuan, Okay, will use "textContent" instead.

Copy link
Contributor

@cjyuan cjyuan Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also write a function to escape the special characters in the string. (Just ask AI. The function is just a few lines of code).

Then you would be able to express something like:

      `...
      <td>${escape(book.title)}</td>
      <td>${escape(book.author)}</td>
      ...
      `

This way, you can keep using your approach to construct the elements.

<td>${book.pages}</td>
<td>
<button
class="btn btn-sm ${book.read ? "btn-success" : "btn-secondary"}"
data-index="${index}"
data-action="toggle"
>
${book.read ? "Yes" : "No"}
</button>
</td>
<td>
<button
class="btn btn-sm btn-danger"
data-index="${index}"
data-action="delete"
>
Delete
</button>
</td>
`;

tableBody.appendChild(row);
});
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);

tableBody.addEventListener("click", (event) => {
const button = event.target.closest("button");
if (!button) return;

const index = Number(button.dataset.index);
const action = button.dataset.action;


if (action === "toggle") {
library[index].read = !library[index].read;
render();
}
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
});
if (action === "delete") {
const removedTitle = library[index].title;
library.splice(index, 1);
render();
alert(`Deleted: ${removedTitle}`);
}
}
});


render();