CodeYourFuture · AhmadHmedann · Dec 16, 2025 · Dec 16, 2025 · Dec 16, 2025 · Dec 16, 2025
diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html
@@ -1,11 +1,10 @@
 <!DOCTYPE html>
 <html>
   <head>
-    <title> </title>
+    <title>Book Library </title>
     <meta
       charset="utf-8"
-      name="viewport"
-      content="width=device-width, initial-scale=1.0"
+
     />
     <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
     <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
@@ -31,15 +30,15 @@ <h1>Library</h1>
       <div class="form-group">
         <label for="title">Title:</label>
         <input
-          type="title"
+          type="text"
           class="form-control"
           id="title"
           name="title"
           required
         />
         <label for="author">Author: </label>
         <input
-          type="author"
+          type="text"
           class="form-control"
           id="author"
           name="author"
@@ -65,7 +64,7 @@ <h1>Library</h1>
           type="submit"
           value="Submit"
           class="btn btn-primary"
-          onclick="submit();"
+          id="submitBtn"
         />
       </div>
     </div>
@@ -80,7 +79,7 @@ <h1>Library</h1>
           <th></th>
         </tr>
       </thead>
-      <tbody>
+      <tbody id="tbody">
         <tr>
           <td></td>
           <td></td>
@@ -91,6 +90,6 @@ <h1>Library</h1>
       </tbody>
     </table>
 
-    <script src="script.js"></script>
+    <script src="script.js" type="module"></script>
   </body>
 </html>
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js
@@ -1,44 +1,51 @@
 let myLibrary = [];
 
+const titleInput = document.getElementById("title");
+const authorInput = document.getElementById("author");
+const pagesInput = document.getElementById("pages");
+const isReadInput = document.getElementById("check");
+
+const submitBtn = document.getElementById("submitBtn");
+submitBtn.addEventListener("click", submit);
+
 window.addEventListener("load", function (e) {
   populateStorage();
   render();
 });
 
+//just one thing need to check
 function populateStorage() {
-  if (myLibrary.length == 0) {
-    let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
+  if (myLibrary.length === 0) {
+    let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
     let book2 = new Book(
       "The Old Man and the Sea",
       "Ernest Hemingway",
-      "127",
+      127,
       true
     );
     myLibrary.push(book1);
     myLibrary.push(book2);
-    render();
   }
 }
 
-const title = document.getElementById("title");
-const author = document.getElementById("author");
-const pages = document.getElementById("pages");
-const check = document.getElementById("check");
-
 //check the right input from forms and if its ok -> add the new book (object in array)
 //via Book function and start render function
 function submit() {
-  if (
-    title.value == null ||
-    title.value == "" ||
-    pages.value == null ||
-    pages.value == ""
-  ) {
+  //if any of the information is missing show an alert
+  const titleValue = titleInput.value.trim();
+  const authorValue = authorInput.value.trim();
+  const pagesValue = Number(pagesInput.value);
+  if (!titleValue || !authorValue || !pagesValue || pagesValue < 0) {
     alert("Please fill all fields!");
-    return false;
+    return;
   } else {
-    let book = new Book(title.value, title.value, pages.value, check.checked);
-    library.push(book);
+    let book = new Book(
+      titleValue,
+      authorValue,
+      pagesValue,
+      isReadInput.checked
+    );
+    myLibrary.push(book);
     render();
   }
 }
@@ -52,51 +59,48 @@ function Book(title, author, pages, check) {
 
 function render() {
   let table = document.getElementById("display");
-  let rowsNumber = table.rows.length;
-  //delete old table
-  for (let n = rowsNumber - 1; n > 0; n-- {
-    table.deleteRow(n);
-  }
+  const tableBody = document.getElementById("tbody");
+  tableBody.textContent = "";
   //insert updated row and cells
   let length = myLibrary.length;
   for (let i = 0; i < length; i++) {
-    let row = table.insertRow(1);
-    let titleCell = row.insertCell(0);
+    let row = tableBody.insertRow(); // why (1) not i+1 insert <tr> with four <td>
+    let titleCell = row.insertCell(0); // the table.rows and row.cells are HTMLCollection,not a real array, but they behave like array(indexed,length) . they are DOM collections
     let authorCell = row.insertCell(1);
     let pagesCell = row.insertCell(2);
     let wasReadCell = row.insertCell(3);
-    let deleteCell = row.insertCell(4);
-    titleCell.innerHTML = myLibrary[i].title;
-    authorCell.innerHTML = myLibrary[i].author;
-    pagesCell.innerHTML = myLibrary[i].pages;
+    let deleteCell = row.insertCell(4); // it is like insert for <td> </td>
+    titleCell.textContent = myLibrary[i].title; //filling the cells    why innerHTML
+    authorCell.textContent = myLibrary[i].author;
+    pagesCell.textContent = myLibrary[i].pages;
 
     //add and wait for action for read/unread button
-    let changeBut = document.createElement("button");
-    changeBut.id = i;
-    changeBut.className = "btn btn-success";
-    wasReadCell.appendChild(changeBut);
+    let changeReadBut = document.createElement("button");
+    changeReadBut.className = "btn btn-success";
+    wasReadCell.appendChild(changeReadBut);
     let readStatus = "";
-    if (myLibrary[i].check == false) {
+    if (myLibrary[i].check === true) {
       readStatus = "Yes";
     } else {
       readStatus = "No";
     }
-    changeBut.innerText = readStatus;
+    changeReadBut.textContent = readStatus;
 
-    changeBut.addEventListener("click", function () {
+    changeReadBut.addEventListener("click", function () {
       myLibrary[i].check = !myLibrary[i].check;
       render();
     });
 
     //add delete button to every row and render again
-    let delButton = document.createElement("button");
-    delBut.id = i + 5;
-    deleteCell.appendChild(delBut);
-    delBut.className = "btn btn-warning";
-    delBut.innerHTML = "Delete";
-    delBut.addEventListener("clicks", function () {
-      alert(`You've deleted title: ${myLibrary[i].title}`);
+
+    let deleteBut = document.createElement("button");
+    deleteCell.appendChild(deleteBut);
+    deleteBut.className = "btn btn-warning";
+    deleteBut.textContent = "Delete";
+    deleteBut.addEventListener("click", function () {
+      const DeletedTitle = myLibrary[i].title;
       myLibrary.splice(i, 1);
+      alert(`You've deleted title: ${DeletedTitle}`);
       render();
     });
   }