Skip to content

Manchester| 25-ITP-SEP| Fithi Teklom| Sprint 2 | Book Library #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fithi-Teklom wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Manchester| 25-ITP-SEP| Fithi Teklom| Sprint 2 | Book Library #361

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5101361
debugged the issue on the javascript file and modified html file.
Fithi-Teklom Dec 16, 2025
8be6584
formatted it in the first place
Fithi-Teklom Dec 18, 2025
69ea84e
removed unnecessary slashes
Fithi-Teklom Dec 18, 2025
c719ec1
some adjustments
Fithi-Teklom Dec 18, 2025
b8cfc20
used html validator and there is no error
Fithi-Teklom Dec 18, 2025
333f269
made some modifications in the js file
Fithi-Teklom Dec 18, 2025
db2bff7
wrote a conditional statement in a single statement
Fithi-Teklom Dec 19, 2025
536e55a
assign the DOM via textContent
Fithi-Teklom Dec 19, 2025
cfe2650
removed unnecessary variables
Fithi-Teklom Dec 19, 2025
bee984d
made some changes
Fithi-Teklom Dec 19, 2025
ff8a6ea
fixed the bug
Fithi-Teklom Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 15 additions & 22 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,13 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Book Library</title>
<meta charset="utf-8">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css">
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<body>
Expand All @@ -31,42 +24,42 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>
>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
>Read
</label>
<input
type="submit"
type="button"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
onclick="addBook();"
>
</div>
</div>

Expand All @@ -93,4 +86,4 @@ <h1>Library</h1>

<script src="script.js"></script>
</body>
</html>
</html>
69 changes: 35 additions & 34 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,15 @@ window.addEventListener("load", function (e) {

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
myLibrary.push(book1,book2);

}
}

Expand All @@ -27,20 +26,21 @@ const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
function addBook() {
if (!title.value.trim() || !author.value.trim() || !pages.value.trim()) {
alert("Please fill all fields!");
return false;
}
Copy link
Contributor

@cjyuan cjyuan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.


let pagesNumber = parseInt(pages.value, 10);
if (isNaN(pagesNumber)) {
alert("Page count must be a number!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
let book = new Book(title.value.trim(), author.value.trim(), pagesNumber, check.checked);
Copy link
Contributor

@cjyuan cjyuan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could consider saving preprocessed and sanitised input in some variables first to

    • improve performance
    • to avoid accidently using raw input later

  • Not all integers are valid number of pages.

myLibrary.push(book);
render();

}

function Book(title, author, pages, check) {
Expand All @@ -54,7 +54,7 @@ function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n-- ) {
table.deleteRow(n);
}
Copy link
Contributor

@cjyuan cjyuan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider using a more efficient approach to clear the table.

//insert updated row and cells
Expand All @@ -66,35 +66,36 @@ function render() {
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
Comment on lines 76 to 77
Copy link
Contributor

@cjyuan cjyuan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a variable is not going to be reassigned a value, it is best practice to declare the variable using const.

let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;


//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let toggleReadBtn = document.createElement("button");
toggleReadBtn.dataset.index = i;
Copy link
Contributor

@cjyuan cjyuan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this statement? Where is the assigned value used in your code?

toggleReadBtn.className = "btn btn-success";
wasReadCell.appendChild(toggleReadBtn);
let readStatus = "";
if (myLibrary[i].check == false) {
if (myLibrary[i].check == true) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
toggleReadBtn.innerText = readStatus;
Copy link
Contributor

@cjyuan cjyuan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a good opportunity to practice using the ? : conditional operator. Can you rewrite the code on lines 79–85 as a single statement?


changeBut.addEventListener("click", function () {
toggleReadBtn.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
let deleteBtn = document.createElement("button");
deleteBtn.dataset.index = i;
deleteCell.appendChild(deleteBtn);
deleteBtn.className = "btn btn-warning";
deleteBtn.innerHTML = "Delete";
Copy link
Contributor

@cjyuan cjyuan Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why assign text to a DOM element via three different properties?

  • 'textContent` on line 71
  • innerText on line 85
  • innerHTML on line 97

deleteBtn.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down