Skip to content

Manchester| 25-ITP-Sep| Fithi Teklom| Sprint 3 | Alarm Clock #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fithi-Teklom wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Manchester| 25-ITP-Sep| Fithi Teklom| Sprint 3 | Alarm Clock #908

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8085c0c
added a tittle element
Fithi-Teklom Dec 2, 2025
b3ad0d8
updated the title
Fithi-Teklom Dec 2, 2025
d33934f
added a jest.config.js file
Fithi-Teklom Dec 5, 2025
9c3ee51
passed all the tests
Fithi-Teklom Dec 6, 2025
bffd4b4
checked an empty value first and any error
Fithi-Teklom Dec 10, 2025
7ded280
removed pauseAlarm from stop alarm function
Fithi-Teklom Dec 18, 2025
c9aa8f1
reset any flashing and playing audio
Fithi-Teklom Dec 18, 2025
0b85c7a
added space
Fithi-Teklom Dec 18, 2025
e618de2
removed the set button variable
Fithi-Teklom Dec 18, 2025
76f1971
alarm starts immediately
Fithi-Teklom Dec 18, 2025
b6af9d4
formatted it
Fithi-Teklom Dec 18, 2025
fc92b97
wrapped an implementation inside a function
Fithi-Teklom Dec 18, 2025
0c30fdd
modifications are made when timer is set to 0
Fithi-Teklom Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 86 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,89 @@
function setAlarm() {}


// function setAlarm() {}

let timeLeft = 0;
let timer = null;
let flashing = null;

// DOM references
window.addEventListener("DOMContentLoaded", () => {
// const display = document.getElementById("timeRemaining");
const setButton = document.getElementById("set");
const stopButton = document.getElementById("stop");

// Event listeners
// if (setButton) setButton.addEventListener("click", () => playAlarm());
if (stopButton) stopButton.addEventListener("click", stopAlarm);

// Show 00:00 on load
updateDisplay(0);
});

// -------------------------------
// FUNCTIONS
// -------------------------------

function setAlarm() {
const input = document.getElementById("alarmSet").value;
const parsed = parseInt(input, 10);

if (isNaN(parsed) || parsed < 0) return;
Copy link

@JaypeeLan JaypeeLan Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check for an empty value first. Also alert an error if any.

Copy link
Author

@Fithi-Teklom Fithi-Teklom Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, can you please review my PR again it has been a while. step 3 has not approved because this PR is still in needs review


timeLeft = parsed;

// Update display immediately
updateDisplay(timeLeft);

// Clear previous countdown
clearInterval(timer);

// Start countdown every 1000ms
timer = setInterval(() => {
if (timeLeft > 0) {
timeLeft--;
updateDisplay(timeLeft);
}

if (timeLeft === 0) {
clearInterval(timer);
startAlarm();
}
}, 1000);
}
Copy link
Contributor

@cjyuan cjyuan Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alarm will start 1 second after the alarm is set when the input is either 0 or 1.
That is, when the input is zero, the alarm will only start 1 second afterward (and not immediately).
Can you improve the consistency?


function updateDisplay(seconds) {
const mins = String(Math.floor(seconds / 60)).padStart(2, "0");
const secs = String(seconds % 60).padStart(2, "0");

const display = document.getElementById("timeRemaining");
if (!display) return;
display.textContent = `Time Remaining: ${mins}:${secs}`;
}

function startAlarm() {
playAlarm();

// Flashing background
if (!flashing){
flashing = setTimeout(() => {
document.body.style.backgroundColor =
document.body.style.backgroundColor === "red" ? "orange" : "red";
}, 300);
}
}

function stopAlarm() {
if (typeof pauseAlarm === "function") pauseAlarm();

clearInterval(flashing);
flashing = null;
document.body.style.backgroundColor = "";
}


// module.exports= setAlarm;


// DO NOT EDIT BELOW HERE

Expand Down
10 changes: 7 additions & 3 deletions Sprint-3/alarmclock/alarmclock.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ There are some Tests in this file that will help you work out if your code is wo
*/

const path = require("path");
// const { setAlarm } = require("./alarmclock.js");

const { JSDOM } = require("jsdom");

let page = null;
Expand Down Expand Up @@ -35,6 +37,8 @@ afterEach(() => {
page = null;
});



test("should set heading when button is clicked", () => {
const heading = page.window.document.querySelector("#timeRemaining");
const input = page.window.document.querySelector("#alarmSet");
Expand Down Expand Up @@ -89,16 +93,16 @@ test("should count down every 1000 ms", () => {

test("should play audio when the timer reaches zero", () => {
const input = page.window.document.querySelector("#alarmSet");
const button = page.window.document.querySelector("#set");
const startButton = page.window.document.querySelector("#set");
const mockPlayAlarm = jest.fn();

page.window.playAlarm = mockPlayAlarm;
input.value = "10";
button.click();
startButton.click();

expect(mockPlayAlarm).toHaveBeenCalledTimes(0);

jest.runAllTimers();

expect(mockPlayAlarm).toHaveBeenCalledTimes(1);
});
4 changes: 2 additions & 2 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock-app</title>
</head>
<body>
<div class="centre">
Expand All @@ -15,6 +15,6 @@ <h1 id="timeRemaining">Time Remaining: 00:00</h1>
<button id="set" type="button">Set Alarm</button>
<button id="stop" type="button">Stop Alarm</button>
</div>
<script src="alarmclock.js"></script>
<script src="alarmclock.js" defer></script>
</body>
</html>
6 changes: 6 additions & 0 deletions Sprint-3/alarmclock/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/** @type {import('jest').Config} */
module.exports = {
testEnvironment: "jsdom",
verbose: true,
testMatch: ["**/*.test.js"],
};
6 changes: 5 additions & 1 deletion Sprint-3/alarmclock/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,9 @@
"bugs": {
"url": "https://github.com/CodeYourFuture/CYF-Coursework-Template/issues"
},
"homepage": "https://github.com/CodeYourFuture/CYF-Coursework-Template#readme"
"homepage": "https://github.com/CodeYourFuture/CYF-Coursework-Template#readme",
"dependencies": {
"@testing-library/jest-dom": "^6.9.1",
"jest": "^27.5.1"
}
}