Birmingham | 25-ITP-Sep | Hadi-Vahidi | Sprint 3 |sprint-3-implement-and-rewrite #804

HadiVahidi20 · 2025-10-24T17:08:33Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

All implemented tests are completed.

Questions

…lity

github-actions · 2025-10-24T17:08:51Z

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-24T17:09:12Z

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan

The changes (file additions) made in the Sprint-1 and Sprint-2 folder are not related to Sprint-3 exercise. Can you revert the changes made in that two folders?
Can you check out this PR Guide and update the PR title and PR description accordingly?

cjyuan · 2025-10-27T16:06:07Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

+  if(numerator===denominator){
+    return false
+  }
+  if((Math.abs(numerator))<denominator){
+    return true
+  }
+   if (numerator > denominator) {
+    return false;
+  }
+  if (denominator === 0){
+    return false
+  }


The statements in the function are evaluated in the order they appear in the code. As soon as the condition on line 11 is evaluated to true, the function would have returned true immediately. However, -3/2 is not a proper fraction.

The spec does not specify whether denominator can be negative or not.
How would you update the function so that it would work equally well when denominator is negative?

If you are up the some challenge, try simplify the code to use at most one if-statement.

cjyuan · 2025-10-27T16:07:26Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  // for (let i=1; i<10; i++){
+  //   if (i==5){
+  //    return rank === "5"
+  //   }
+  // }


Why keep this code in a comment?

I was trying to use for loop and forgot to delete it. sorry

cjyuan · 2025-10-27T16:09:19Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test ("should return true for negative Fraction",()=>{
+  expect(isProperFraction(-4,7)).toEqual(true);
+});


The test description could be misleading.

-3/2 is not a proper fraction, so isProperFraction(-3,2) should return false.

cjyuan · 2025-10-27T16:10:43Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

+test ("should return a 5 for the card with rank of 5 like(5♥) ",()=>{
+  const fiveofHearts = getCardValue("5♥");
+  expect(fiveofHearts).toEqual(5);
+
+})


When preparing tests, we should ensure the tests cover all possible cases. If we specify a test for individual rank, we will need about 13 tests to cover all possible cases. Instead, we could consider classifying all possible values into different categories, and then within each category we test some samples.

For example, one possible category for getCardValue() is, "should return the value of number cards (2-10)", and we can prepare the test as

test("should return the value of number cards (2-10)", () => { expect(getCardValue("2♣︎")).toEqual(2); expect(getCardValue("5♠")).toEqual(5); expect(getCardValue("10♥")).toEqual(10); // Note: We could also use a loop to check all values from 2 to 10. });

cjyuan · 2025-10-27T16:11:48Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

+
+})
 // Case 3: Handle Face Cards (J, Q, K):
+test("shoild return 10 fore the faced cart like king(K♦) and queen (Q♣)")


Few words are misspelled

Could also include J

github-actions · 2025-10-27T16:13:47Z

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-27T16:13:47Z

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan

Changes look good. It seems you had a different definition of pure fraction.

cjyuan · 2025-10-31T19:14:27Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

  }
-  if (denominator === 0){
-    return false
+  if (numerator < denominator && numerator > -denominator) {


In math, 2/-3 is equal to -2/3, and -2/-3 = 2/3.
So ideally isProperFraction(2, -3) and isProperFraction(-2, -3) should also true.

Suggestion: Look up the definition of proper fraction.

…ing Math.abs to input numbers

cjyuan · 2025-11-01T20:41:28Z

Changes look good.

HadiVahidi20 added 13 commits September 29, 2025 17:45

Add age calculation functionality and HTML structure for age input

1189fcd

Refactor age calculator layout and improve form structure

78b6a33

addWnetListener Example added

ea977e5

Refactor age calculator layout and improve form structure

22c0fee

percentage exersice added

c346f52

Enhance percentage exercise layout and add area calculation functiona…

ea0fca9

…lity

Implement getAngleType function with all angle cases and tests

cfb55de

Implement isProperFraction function with basic tests

6937b06

exercise 3 is done

ac30244

Add Jest tests for getAngleType function

7ce4235

added jest test for 2-is-proper-faction

54e91ad

added jest test for3-get-card-value

f3203bb

all sprint 3 implement task are done.

b823e9c

HadiVahidi20 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 24, 2025

cjyuan reviewed Oct 27, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 27, 2025

HadiVahidi20 added 3 commits October 31, 2025 18:15

the proper function is now correct

36c74ca

the proper fraction test is corrected

fd49b18

simplify getCardValue tests using categorical approach

09eec6d

HadiVahidi20 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 31, 2025

cjyuan reviewed Oct 31, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 31, 2025

Fix isProperFraction to handle negative denominators correctly by add…

7dd99dd

…ing Math.abs to input numbers

HadiVahidi20 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 31, 2025

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 1, 2025

HadiVahidi20 mentioned this pull request Nov 15, 2025

ITP Sep 2025 | Structuring and testing data | Hadi Vahidi HadiVahidi20/My-Coursework-Planner#7

Open

Uh oh!

Birmingham | 25-ITP-Sep | Hadi-Vahidi | Sprint 3 |sprint-3-implement-and-rewrite #804

Are you sure you want to change the base?

Birmingham | 25-ITP-Sep | Hadi-Vahidi | Sprint 3 |sprint-3-implement-and-rewrite #804

Uh oh!

Conversation

HadiVahidi20 commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Oct 24, 2025

Uh oh!

github-actions bot commented Oct 24, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

HadiVahidi20 Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Nov 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HadiVahidi20 commented Oct 24, 2025 •

edited

Loading