-
Notifications
You must be signed in to change notification settings - Fork 31
build: bump yarn to 3.8.7 #3219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit 3254e04 ☁️ Nx Cloud last updated this comment at |
dreamwasp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great and matches all the yarn migration docs! only not approving since you're branching off of this for yarn 4.
.github/actions/yarn/action.yml
Outdated
| - name: Install dependencies | ||
| shell: bash | ||
| run: yarn --production=false --frozen-lockfile | ||
| run: corepack enable && yarn config set nodeLinker node-modules && yarn install --immutable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw corepack shouldn't technically be necessary b/c you have the yarn binary in .yarn/releases , and nodeLinker is set in the .yarnrc. we've used this pattern in dockerfiles before because they don't have access to those files, but in CI they should be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just so i understand, you're saying i can just have this as yarn install --immutable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that's what i meant. That said, after i wrote this in Bana's PR we went the other way and removed the binary from the repo and relied entirely on corepack.
So maybe we keep this, but you should be able to simplify it to:
corepack enable && yarn install --immutable
since nodeLinker is already set in the .yarnrc.yml file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to do the same in this repo? i can do it in the yarn 4 branch if so
|
📬 Published Alpha Packages: |
|
🚀 Styleguide deploy preview ready! Preview URL: https://6961511bd38f0755987a4e03--gamut-preview.netlify.app |
Overview
Bumps yarn to 3.8.7 to match mono. Note: probably won't merge this and instead will branch off of it to bump to yarn 4
PR Checklist
Testing Instructions
PR Links and Envs