Skip to content

Conversation

@aresnik11
Copy link
Contributor

@aresnik11 aresnik11 commented Nov 24, 2025

Overview

Bumps yarn to 3.8.7 to match mono. Note: probably won't merge this and instead will branch off of it to bump to yarn 4

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1464
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to storybook preview
  2. Confirm everything works as expected
  3. Pull the branch locally
  4. Go to storybook
  5. Confirm everything works as expected
  6. Confirm the alpha works in mono/lith
  7. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Nov 24, 2025

View your CI Pipeline Execution ↗ for commit 3254e04


☁️ Nx Cloud last updated this comment at 2026-01-09 19:01:44 UTC

@aresnik11 aresnik11 changed the title bump yarn build: bump yarn to 3.8.7 Dec 17, 2025
@aresnik11 aresnik11 marked this pull request as ready for review December 17, 2025 19:28
@aresnik11 aresnik11 requested a review from a team as a code owner December 17, 2025 19:28
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great and matches all the yarn migration docs! only not approving since you're branching off of this for yarn 4.

- name: Install dependencies
shell: bash
run: yarn --production=false --frozen-lockfile
run: corepack enable && yarn config set nodeLinker node-modules && yarn install --immutable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw corepack shouldn't technically be necessary b/c you have the yarn binary in .yarn/releases , and nodeLinker is set in the .yarnrc. we've used this pattern in dockerfiles before because they don't have access to those files, but in CI they should be there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just so i understand, you're saying i can just have this as yarn install --immutable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's what i meant. That said, after i wrote this in Bana's PR we went the other way and removed the binary from the repo and relied entirely on corepack.

So maybe we keep this, but you should be able to simplify it to:

corepack enable && yarn install --immutable

since nodeLinker is already set in the .yarnrc.yml file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to do the same in this repo? i can do it in the yarn 4 branch if so

@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

eslint-plugin-gamut@2.4.1-alpha.247c6e.0
@codecademy/gamut@67.6.3-alpha.247c6e.0
@codecademy/gamut-icons@9.54.1-alpha.247c6e.0
@codecademy/gamut-illustrations@0.57.1-alpha.247c6e.0
@codecademy/gamut-kit@0.6.576-alpha.247c6e.0
@codecademy/gamut-patterns@0.10.20-alpha.247c6e.0
@codecademy/gamut-styles@17.11.1-alpha.247c6e.0
@codecademy/gamut-tests@5.2.18-alpha.247c6e.0
@codecademy/variance@0.25.1-alpha.247c6e.0

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants