Prevent duplicate footer menu IDs - #4568
Open
girishpanchal30 wants to merge 8 commits into
Open
Conversation
pirate-bot
added
the
pr-checklist-complete
Collaborator
There was a problem hiding this comment.
Pull request overview
Prevents duplicate Footer Menu IDs across responsive footer layouts.
Changes:
- Qualifies menu IDs with device and row.
- Updates hover styling to use the stable menu class.
- Adds dual-layout E2E coverage and fixture.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
header-footer-grid/templates/components/component-nav-footer.php |
Generates contextual menu IDs. |
header-footer-grid/Core/Components/NavFooter.php |
Uses class-based hover targeting. |
e2e-tests/specs/customizer/hfg/hfg-footer-menu-unique-id.spec.ts |
Tests responsive ID uniqueness. |
e2e-tests/fixtures/customizer/hfg/footer-menu-both-devices-setup.json |
Configures menus in both layouts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
e2e-tests/specs/customizer/hfg/hfg-footer-menu-component.spec.ts:156
- Correct the comment typo: “postfooter-menu” should be “footer-menu”.
// Changing a postfooter-menu setting refreshes the component partial.
selul
approved these changes
Aug 12, 2026
selul
approved these changes
Aug 13, 2026
Soare-Robert-Daniel
approved these changes
Aug 14, 2026
Contributor
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # e2e-tests/specs/customizer/hfg/hfg-menu-item-alignment.spec.ts Co-authored-by: selul <3330746+selul@users.noreply.github.com>
selul
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the current device and row to the menu ID to ensure it's unique when the component is used in multiple rows or across both desktop and mobile layouts.
Check before Pull Request is ready:
Closes #4557