fix: update sharing status label#1075
Open
girishpanchal30 wants to merge 1 commit intodevelopmentfrom
Open
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the dashboard “Sharing Status” label not updating after Start/Stop actions by making the StatusBox title/description derived reactively from the label prop (instead of being computed once at component creation).
Changes:
- Replaced
data()-derivedtitle/descriptionwith computed properties so the UI updates whenlabelchanges.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+60
to
+64
| title() { | ||
| return this.label.split(':')[0] | ||
| }, | ||
| description() { | ||
| return this.label.split(':')[1] |
Comment on lines
+59
to
66
| computed: { | ||
| title() { | ||
| return this.label.split(':')[0] | ||
| }, | ||
| description() { | ||
| return this.label.split(':')[1] | ||
| } | ||
| } |
Soare-Robert-Daniel
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a computed property to update the label of the sharing status.
Check before Pull Request is ready:
Closes #1048