feat: improve import from WordPress and database UX with stepped flow#1284
Open
HardeepAsrani wants to merge 2 commits intodevelopmentfrom
Open
feat: improve import from WordPress and database UX with stepped flow#1284HardeepAsrani wants to merge 2 commits intodevelopmentfrom
HardeepAsrani wants to merge 2 commits intodevelopmentfrom
Conversation
- Rename "Create Filter"/"Create Query" buttons to "1. Choose Data Source" - Add "2. Set Sync Schedule" accordion toggle (always visible, animated chevron) - Move schedule selector under step-2 toggle for cleaner stepped UX
pirate-bot
added
the
pr-checklist-complete
Contributor
| do_action( 'visualizer_chart_schedules_spl', 'db', $chart_id, 1 ); | ||
| $is_db_source = 'visualizer_source_query' === $source_of_chart; | ||
| $hours = get_post_meta( $chart_id, Visualizer_Plugin::CF_DB_SCHEDULE, true ); | ||
| $bttn_label = $is_db_source ? __( '1. Modify Data Source', 'visualizer' ) : __( '1. Choose Data Source', 'visualizer' ); |
Contributor
There was a problem hiding this comment.
Do you think it can work to put 1. and 2. as a prefix for those strings? This is to prevent changing the string in case of a re-order.
Contributor
|
@HardeepAsrani can we also maybe close the "Set Sync Schedule" dropdown when the user clicks on the "Save schedule" button, as right now, the button acts like nothing is saving when clicking on it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rodica-andronache I had implemented your suggestion but the UX was not looking the best with buttons so I've made some changes. Let me know what you feel or should I revert to the ones suggested in the issue.
Pro PR: https://github.com/Codeinwp/visualizer-pro/pull/572
Will affect visual aspect of the product
YES/NO
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/visualizer-pro/issues/518.