fix: render lazy charts already in viewport on page load#1287
Open
HardeepAsrani wants to merge 1 commit intodevelopmentfrom
Open
fix: render lazy charts already in viewport on page load#1287HardeepAsrani wants to merge 1 commit intodevelopmentfrom
HardeepAsrani wants to merge 1 commit intodevelopmentfrom
Conversation
The scroll listener for lazy charts never fired if the chart was already visible on page load, causing it to remain blank until the user scrolled. Extracted the logic into a named function with a viewport bounds check and call it once at page load in addition to on scroll.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scroll listener for lazy charts never fired if the chart was already visible on page load, causing it to remain blank until the user scrolled. Extracted the logic into a named function with a viewport bounds check and call it once at page load in addition to on scroll.
Will affect visual aspect of the product
No
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/visualizer-pro/issues/526.