Metrics Panel Fixes #280
Open
Metrics Panel Fixes #280
+136
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 8, 2026 15:53
…eta-anno metrics. Better error handling on the frontend for failed reports. tooltip provides error msg
…again for meta-cat train / test split issues.
mart-r
approved these changes
Jan 9, 2026
Collaborator
mart-r
left a comment
mart-r
left a comment
There was a problem hiding this comment.
Looks good to me.
Only a question about the CDB load validation part. Though it would certainly be outside the scope of this PR if that needs to be done.
| raise FileNotFoundError(f'CDB not found in model pack: {unpacked_model_pack_path}') | ||
|
|
||
| # Validate CDB can be loaded | ||
| CDB.load(cdb_path_abs) |
Collaborator
There was a problem hiding this comment.
This can be quite a heavy task. Perhpas there should be a validation method on some of these to validate that MedCAT knows how to load them? Though wouldn't necessarily guarantee anything...
Though obviously not much has change from before. So nothing major.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
medcatmeta-anno