feat: dockerization by angelacorte · Pull Request #613 · Collektive/collektive-examples

angelacorte · 2025-12-05T11:09:05Z

No description provided.

…tion

DanySK · 2026-02-22T15:45:57Z

@nicolasfara @cric96 @angelacorte
Can the three of you deal with this? I trust your judgment

Copilot

Pull request overview

This PR adds Docker containerization support to the collektive-examples project, enabling the project to run simulations and generate charts in isolated containers. The changes also include automated release configuration using semantic-release to build and publish Docker images.

Changes:

Added Docker configuration for running simulations and generating charts in containers
Integrated semantic-release automation for versioning, Docker image building/publishing, and artifact management
Added Python plotting scripts for data visualization and analysis

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 28 comments.

Show a summary per file

File	Description
release.config.js	Configures semantic-release to automate versioning, Docker builds, and GitHub releases
plotter_all.py	Main Python script for generating various data visualization charts from experiment results
plot_utils.py	Utility functions for data processing and chart generation using Alchemist simulation data
docker/sim/Dockerfile	Container image for running Alchemist simulation experiments with Gradle
docker/charts/Dockerfile	Container image for running Python-based chart generation (incomplete)
docker-compose.yml	Orchestrates multiple services for data preparation, simulation execution, and cleanup
.env	Environment variables for Docker image versioning and project naming
.dockerignore	Excludes unnecessary files from Docker build context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-22T15:52:32Z

docker/charts/Dockerfile

+FROM python:3.13.7
+RUN mkdir /experiment
+WORKDIR /experiment
+COPY .python-version ./


The file '.python-version' is referenced in the COPY instruction but does not appear to exist in the repository. This will cause the Docker build to fail. Either create this file or remove this line if it's not necessary for the build.

Suggested change

COPY .python-version ./

Copilot · 2026-02-22T15:52:32Z

docker-compose.yml

+      context: .
+      dockerfile: docker/sim/Dockerfile
+    volumes:
+      - angela.cortecchia-volume:/experiment/data


The volume 'angela.cortecchia-volume' is used but never defined in the docker-compose.yml file. Docker Compose will create an external volume reference, but this should either be declared in a top-level 'volumes' section or changed to a bind mount like './data:/experiment/data' to match the pattern used in commented services and the 'finish' service.

Suggested change

- angela.cortecchia-volume:/experiment/data

- ./data:/experiment/data

Copilot · 2026-02-22T15:52:33Z

plotter_all.py

+    all = []
+    for seed in data.seed.values:
+        current_data = data.sel(seed=seed.item())
+        max_moving_time = current_data["lastMovingTime[max]"].max().item()
+        all.append(max_moving_time)
+    return all
+
+def extract_max_replanning_from_full(data):
+    all = []
+    for seed in data.seed.values:
+        current_data = data.sel(seed=seed.item())
+        max_replanning = current_data["totalReplanning[mean]"].max().item()
+        all.append(max_replanning)
+    return all


The variable 'all' is a Python built-in function and should not be used as a variable name. This shadows the built-in and is considered a bad practice. Consider renaming it to something more descriptive like 'replanning_counts' or 'max_replanning_values'.

Suggested change

all = []

for seed in data.seed.values:

current_data = data.sel(seed=seed.item())

max_moving_time = current_data["lastMovingTime[max]"].max().item()

all.append(max_moving_time)

return all

def extract_max_replanning_from_full(data):

all = []

for seed in data.seed.values:

current_data = data.sel(seed=seed.item())

max_replanning = current_data["totalReplanning[mean]"].max().item()

all.append(max_replanning)

return all

max_times = []

for seed in data.seed.values:

current_data = data.sel(seed=seed.item())

max_moving_time = current_data["lastMovingTime[max]"].max().item()

max_times.append(max_moving_time)

return max_times

def extract_max_replanning_from_full(data):

max_replanning_values = []

for seed in data.seed.values:

current_data = data.sel(seed=seed.item())

max_replanning = current_data["totalReplanning[mean]"].max().item()

max_replanning_values.append(max_replanning)

return max_replanning_values

Copilot · 2026-02-22T15:52:33Z

plotter_all.py

+def extract_max_replanning(data, std):
+    max_replanning = data["totalReplanning[mean]"].max().item()
+    # get the index of the first time where lastMovingTime[max] is maximum
+    index = data["totalReplanning[mean]"].argmax().item()
+    # take the minimum of the std at that index
+    min_replanning = data["totalReplanning[mean]"].min().item()
+    std_max_replanning = std["totalReplanning[mean]"].isel(time=index).max().item()
+    return 0, max_replanning


The function 'extract_max_replanning' is defined but never used anywhere in the code. Consider removing it if it's not needed, or add a comment explaining why it's kept for future use.

Suggested change

def extract_max_replanning(data, std):

max_replanning = data["totalReplanning[mean]"].max().item()

# get the index of the first time where lastMovingTime[max] is maximum

index = data["totalReplanning[mean]"].argmax().item()

# take the minimum of the std at that index

min_replanning = data["totalReplanning[mean]"].min().item()

std_max_replanning = std["totalReplanning[mean]"].isel(time=index).max().item()

return 0, max_replanning

Copilot · 2026-02-22T15:52:33Z

release.config.js

+var prepareCmd = `
+echo version=\${nextRelease.version} > gradle.properties
+echo VERSION="\${nextRelease.version}" > .env
+echo PROJECT_NAME=$(grep -Po 'rootProject\\s*\\.\\s*name\\s*=\\s*"\\K[\\w-]+(?=")' settings.gradle.kts) >> .env
+docker compose build
+`
+var publishCmd = `
+docker compose push
+git add gradle.properties .env
+git commit -m "chore(release): update gradle.properties .env versions to \${nextRelease.version} [skip ci]"
+git push
+`
+var config = require('semantic-release-preconfigured-conventional-commits');


The spacing between the variable assignments is inconsistent. Line 1 has no space before or after the '=' operator, which is valid JavaScript but inconsistent with most JavaScript style guides. For better readability, consider using 'const' or 'let' instead of 'var' and adding spaces around the equals sign.

Suggested change

var prepareCmd = `

echo version=\${nextRelease.version} > gradle.properties

echo VERSION="\${nextRelease.version}" > .env

echo PROJECT_NAME=$(grep -Po 'rootProject\\s*\\.\\s*name\\s*=\\s*"\\K[\\w-]+(?=")' settings.gradle.kts) >> .env

docker compose build

`

var publishCmd = `

docker compose push

git add gradle.properties .env

git commit -m "chore(release): update gradle.properties .env versions to \${nextRelease.version} [skip ci]"

git push

`

var config = require('semantic-release-preconfigured-conventional-commits');

const prepareCmd = `

echo version=\${nextRelease.version} > gradle.properties

echo VERSION="\${nextRelease.version}" > .env

echo PROJECT_NAME=$(grep -Po 'rootProject\\s*\\.\\s*name\\s*=\\s*"\\K[\\w-]+(?=")' settings.gradle.kts) >> .env

docker compose build

`

const publishCmd = `

docker compose push

git add gradle.properties .env

git commit -m "chore(release): update gradle.properties .env versions to \${nextRelease.version} [skip ci]"

git push

`

const config = require('semantic-release-preconfigured-conventional-commits');

Copilot · 2026-02-22T15:52:37Z

docker-compose.yml

+    volumes:
+      - angela.cortecchia-volume:/experiment/data
+    environment:
+      - GRADLE_TASK=runGradientBatch


The environment variable GRADLE_TASK is set to 'runGradientBatch' in the docker-compose.yml, but this Gradle task does not exist in the project. Based on the build.gradle.kts file, the task should be 'runGradientBatch' which gets auto-generated from the 'gradient.yml' file. However, the exact task name would be 'runGradientBatch' (capitalized). Please verify the correct task name exists or will be generated.

Suggested change

- GRADLE_TASK=runGradientBatch

- GRADLE_TASK=RunGradientBatch

Copilot · 2026-02-22T15:52:37Z

plotter_all.py

+        legend,
+        {"leader_based": leader_based}
+    )
+


The function 'plot_bar_plot_percentage_time' is referenced in line 312 but is never defined in this file or imported. This will cause a NameError at runtime. Either this function needs to be implemented or the call to 'create_bar_plot' should be removed or commented out.

Suggested change

def plot_bar_plot_percentage_time(*args, **kwargs):

"""

Placeholder plot function used by create_bar_plot.

This function is intentionally implemented as a no-op to avoid a NameError

when passed to create_grid_plot_base. It accepts arbitrary positional and

keyword arguments to remain compatible with whatever call signature

create_grid_plot_base expects for its plotting callbacks.

"""

return

Copilot · 2026-02-22T15:52:37Z

plotter_all.py

+            extract_max_time_from_full(
+                runtime["full"].sel(
+                    totalNodes=node, totalTaskFactor=task_factor, failureTimeAverage=failure_time,
+                    communication=communication, leaderBased=leader_based
+                )
+            )


The result of 'extract_max_time_from_full' is computed but never used. This appears to be dead code that should be removed as it has no effect on the program's behavior.

Suggested change

extract_max_time_from_full(

runtime["full"].sel(

totalNodes=node, totalTaskFactor=task_factor, failureTimeAverage=failure_time,

communication=communication, leaderBased=leader_based

)

)

Copilot · 2026-02-22T15:52:37Z

release.config.js

+echo VERSION="\${nextRelease.version}" > .env
+echo PROJECT_NAME=$(grep -Po 'rootProject\\s*\\.\\s*name\\s*=\\s*"\\K[\\w-]+(?=")' settings.gradle.kts) >> .env


The .env file is overwritten with '>' and then appended to with '>>'. The initial overwrite will destroy any existing environment variables in the .env file. Based on the existing .env file which contains VERSION and PROJECT_NAME, this approach will work, but if there are other variables in .env that need to be preserved, this will lose them. Consider documenting that .env is auto-generated or use a different approach.

Suggested change

echo VERSION="\${nextRelease.version}" > .env

echo PROJECT_NAME=$(grep -Po 'rootProject\\s*\\.\\s*name\\s*=\\s*"\\K[\\w-]+(?=")' settings.gradle.kts) >> .env

tmp_env_file=".env.tmp"

: > "$tmp_env_file"

if [ -f .env ]; then

grep -vE '^(VERSION|PROJECT_NAME)=' .env >> "$tmp_env_file"

fi

echo VERSION="\${nextRelease.version}" >> "$tmp_env_file"

echo PROJECT_NAME=$(grep -Po 'rootProject\\s*\\.\\s*name\\s*=\\s*"\\K[\\w-]+(?=")' settings.gradle.kts) >> "$tmp_env_file"

mv "$tmp_env_file" .env

Copilot · 2026-02-22T15:52:37Z

docker/sim/Dockerfile

+RUN sed -i '/alias(libs.plugins.gitSemVer)/d' build.gradle.kts
+RUN sed -i '/alias(libs.plugins.multiJvmTesting)/d' build.gradle.kts
+RUN sed -i '/multiJvm {/,/}/d' build.gradle.kts
+# Only runs with LEADER_BASED if it's defined in docker-compose


The comment mentions that the service "Only runs with LEADER_BASED if it's defined in docker-compose" but there's no LEADER_BASED environment variable defined in the gossipExperiment service. If this is intentional behavior (defaulting to not leader-based), the comment is misleading. If LEADER_BASED should be configurable, add it to the environment section.

Suggested change

# Only runs with LEADER_BASED if it's defined in docker-compose

# Behavior may be controlled by the LEADER_BASED env var when defined (e.g., via docker-compose)

angelacorte added 2 commits December 5, 2025 12:08

feat: add docker template for launching simulations and charts genera…

a9eabe7

…tion

feat: add plotters

e979246

DanySK requested a review from nicolasfara February 22, 2026 15:45

DanySK assigned nicolasfara, cric96 and angelacorte Feb 22, 2026

DanySK requested a review from cric96 February 22, 2026 15:45

DanySK requested a review from Copilot February 22, 2026 15:46

Copilot started reviewing on behalf of DanySK February 22, 2026 15:46 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: dockerization#613

feat: dockerization#613
angelacorte wants to merge 2 commits intomasterfrom
feat/dockerize

angelacorte commented Dec 5, 2025

Uh oh!

DanySK commented Feb 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Copilot AI Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	- angela.cortecchia-volume:/experiment/data
	- ./data:/experiment/data

	- GRADLE_TASK=runGradientBatch
	- GRADLE_TASK=RunGradientBatch

+def plot_bar_plot_percentage_time(*args, **kwargs):
+    """
+    Placeholder plot function used by create_bar_plot.
+    This function is intentionally implemented as a no-op to avoid a NameError
+    when passed to create_grid_plot_base. It accepts arbitrary positional and
+    keyword arguments to remain compatible with whatever call signature
+    create_grid_plot_base expects for its plotting callbacks.
+    """
+    return

		echo VERSION="\${nextRelease.version}" > .env
		echo PROJECT_NAME=$(grep -Po 'rootProject\\s\\.\\sname\\s=\\s"\\K[\\w-]+(?=")' settings.gradle.kts) >> .env

-echo VERSION="\${nextRelease.version}" > .env
-echo PROJECT_NAME=$(grep -Po 'rootProject\\s*\\.\\s*name\\s*=\\s*"\\K[\\w-]+(?=")' settings.gradle.kts) >> .env
+tmp_env_file=".env.tmp"
+: > "$tmp_env_file"
+if [ -f .env ]; then
+  grep -vE '^(VERSION|PROJECT_NAME)=' .env >> "$tmp_env_file"
+fi
+echo VERSION="\${nextRelease.version}" >> "$tmp_env_file"
+echo PROJECT_NAME=$(grep -Po 'rootProject\\s*\\.\\s*name\\s*=\\s*"\\K[\\w-]+(?=")' settings.gradle.kts) >> "$tmp_env_file"
+mv "$tmp_env_file" .env

	# Only runs with LEADER_BASED if it's defined in docker-compose
	# Behavior may be controlled by the LEADER_BASED env var when defined (e.g., via docker-compose)

Conversation

angelacorte commented Dec 5, 2025

Uh oh!

DanySK commented Feb 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants