Lian countries #10
Open
Lian countries #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
reviewed
Dec 18, 2024
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Please remove all of your non user event listners after finish using them
| <script src="./js/details.js"></script> | ||
| <!-- <script src="./js/common.js"></script> | ||
| <script src="./js/details.js"></script> --> | ||
| </body> |
Member
There was a problem hiding this comment.
Don`t use comments, remove non used code
| const urlParams = new URLSearchParams(window.location.search); | ||
| const name = urlParams.get("name"); | ||
| const flag = urlParams.get("flag"); | ||
| const population = urlParams.get("population"); |
Member
There was a problem hiding this comment.
You should extract this into service and use his methods from there, for example :
paramsService.getValue()
|
|
||
| countryDetailsSection.innerHTML = cardHTML; | ||
| loader.style.display = "none"; | ||
| } else { |
Member
There was a problem hiding this comment.
Please do not use innerHTML its a dangerous method
Also don`t change elements styles from js, use classes.
| @@ -0,0 +1,63 @@ | |||
| document.addEventListener("DOMContentLoaded", () => { | |||
| fetch("CountriesData.json") | |||
| .then(response => { | |||
Member
There was a problem hiding this comment.
Hardcoded strings should be extracted into constant service
| card.setAttribute("href", `details.html?name=${encodeURIComponent(country.name)}&flag=${encodeURIComponent(country.flag)}&population=${country.population}®ion=${encodeURIComponent(country.region)}&capital=${encodeURIComponent(country.capital || "N/A")}`); | ||
| card.querySelector(".country-image").src = country.flag; | ||
| card.querySelector(".country-image").alt = `${country.name} Flag`; | ||
| card.querySelector(".country-title").textContent = country.name; |
Member
There was a problem hiding this comment.
You should save your element and not use 2 querySelectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.