Noa countries #12
Open
Noa countries #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
reviewed
Dec 18, 2024
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Generally don`t use console log
Remove your event listeners after done using them
Hardcoded strings should be inside constants files
| countryElement.setAttribute('data-country-name', country.name); | ||
|
|
||
| countryElement.innerHTML = ` | ||
| <div class="country-flag"> |
Member
There was a problem hiding this comment.
Do not use innerHTML because it is a dangerous method
| dropdownHeader.addEventListener('click', toggleDropdown); | ||
| document.addEventListener('click', closeDropdownOnClickOutside); | ||
| dropdownBody.addEventListener('click', handleRegionSelect); | ||
|
|
Member
There was a problem hiding this comment.
You can wrap this inside a function and call this function
| async function displayCountryDetails() { | ||
| try { | ||
| const urlParams = new URLSearchParams(window.location.search); | ||
| const countryName = urlParams.get('country'); |
Member
There was a problem hiding this comment.
You should extract this into a service exposing the relevant logic as methods
Tamir198
reviewed
Dec 18, 2024
| const loader = document.querySelector('.loader'); | ||
| if (loader) { | ||
| loader.style.display = 'none'; | ||
| } |
Member
There was a problem hiding this comment.
Do not style via js, do it with css classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.