Ofek countries #16
Open
Ofek countries #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilHeller
requested changes
Dec 19, 2024
GilHeller
left a comment
GilHeller
left a comment
There was a problem hiding this comment.
Overall great job.
Consider to write comments only when they are truly needed.
See my comments
js/common.js
Outdated
| * @param {string} param - The name of the query parameter containing the country name. | ||
| * @returns {string|null} - The country name, or null if the parameter doesn't exist. | ||
| */ | ||
| function getQueryParameter(param) { |
js/details.js
Outdated
Comment on lines
46
to
48
| function logError(message) { | ||
| console.error(message); | ||
| } |
js/details.js
Outdated
|
|
||
| /** Finds a country by name in a list of countries. */ | ||
| function findCountryByName(countries, name) { | ||
| return countries.find((country) => country.name === name) || null; |
There was a problem hiding this comment.
Why do you return null? When find not finds a match it returns undefined
js/details.js
Outdated
Comment on lines
18
to
28
| fetchData(jsonFilePath) | ||
| .then((countries) => { | ||
| const country = findCountryByName(countries, countryName); | ||
| if (!country) throw new Error(`Country with name "${countryName}" not found!`); | ||
|
|
||
| clearElementContent(countryDetailsSection); | ||
| countryDetailsSection.appendChild(createCountryElement(country, {isGrid: false})); | ||
| }) | ||
| .catch((error) => logError(error.message || 'Error fetching country details')) | ||
| .finally(() => hideLoader(loader)); | ||
| }); |
There was a problem hiding this comment.
consider using the await syntax instead
js/common.js
Outdated
Comment on lines
135
to
144
| toast.style.position = 'fixed'; | ||
| toast.style.bottom = '10px'; | ||
| toast.style.left = '50%'; | ||
| toast.style.transform = 'translateX(-50%)'; | ||
| toast.style.backgroundColor = '#444'; | ||
| toast.style.color = '#fff'; | ||
| toast.style.padding = '8px 15px'; | ||
| toast.style.borderRadius = '4px'; | ||
| toast.style.fontSize = '14px'; | ||
| toast.style.display = 'none'; |
js/common.js
Outdated
| // Toggle theme on button click | ||
| toggleButton.addEventListener('click', () => { | ||
| const isDark = body.classList.toggle('dark-theme'); // Toggle dark theme class | ||
| localStorage.setItem('theme', isDark ? 'dark' : 'light'); // Save updated theme in localStorage |
There was a problem hiding this comment.
save the hard coded dark mode and light mode values as a const variable.
js/details.js
Outdated
|
|
||
| /** Clears the content of an HTML element. */ | ||
| function clearElementContent(element) { | ||
| if (element) element.innerHTML = ''; |
There was a problem hiding this comment.
Consider using removeChild() instead
const parent = document.getElementById("parent");
const child = document.getElementById("child");
const throwawayNode = parent.removeChild(child);
Author
|
changes are in [Remove .idea .DS_Stor from tracking] commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done with region button and search box filtering