Fetching from JSON and Filtering #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Dec 18, 2024
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
You don't need to explain your code by adding comments, the code should explain it self with meaningful names
| // Load countries from JSON file, once completed use displayCountries to render them | ||
| const loadCountries = async () => { | ||
| const grid = document.getElementById("countries-grid"); | ||
|
|
Member
There was a problem hiding this comment.
Please save your hardcoded strings into constants file
| countries.forEach((country) => { | ||
| const countryElement = document.createElement("a"); | ||
| countryElement.href = "#"; | ||
| countryElement.className = "country scale-effect"; |
Member
There was a problem hiding this comment.
Don't use innerHtmL, its a dangerous method.
| const filterCountries = async (region) => { | ||
| try { | ||
| const response = await fetch("./CountriesData.json"); | ||
| const countries = await response.json(); |
Member
There was a problem hiding this comment.
This function should only do 1 thing and this is to filter the countries.
Extract the get data logic into separate function
| // Load countries when the DOM is fully loaded | ||
| document.addEventListener("DOMContentLoaded", () => { | ||
| loadCountries(); | ||
|
|
Member
There was a problem hiding this comment.
This is a good practice to call dat fetching functions when the app first loads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.