Ran : Add Countries Project #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Dec 18, 2024
| top: 0; | ||
| /* position: fixed; */ | ||
| /* top: 0; */ | ||
| left: 0; |
| display: block; | ||
| max-width: 100%; | ||
| /* max-width: 100%; */ | ||
| object-fit: cover; |
| try { | ||
| loading(isLoading); | ||
| const result = await fetch(`../FullCountriesData.json`); | ||
| if (!result.ok) { |
Member
There was a problem hiding this comment.
Hardcoded strings should be extracted into constants file
| } | ||
| const json = await result.json(); | ||
| // console.log(json); | ||
| return json; |
|
|
||
| if (loader) { | ||
| loader.innerHTML = ` | ||
| <div class="loader"> |
Member
There was a problem hiding this comment.
Don't use innerHTMl, it's a dangerous method
| themeIcon.classList.remove('fa-sun'); | ||
| if (darkMode) { | ||
| document.body.style.backgroundColor = '#ffff'; | ||
| themeText.innerHTML = 'Dark Mode'; |
Member
There was a problem hiding this comment.
Use classes in here as well to style elements.
| if (!countryName) return; | ||
|
|
||
| const myCountry = data?.find(({ name }) => name === countryName); | ||
| console.log(countryName); |
Member
There was a problem hiding this comment.
Good work on destructuring here
| if (name.slice(0, searchLength).toLowerCase() == searchInput) | ||
| return name; | ||
| else if (name[space - 1] === ' ' && name.slice(space, space + searchLength).toLowerCase() == searchInput) | ||
| return name; |
Member
There was a problem hiding this comment.
Extract your complex condition into a variable or a function
| document.addEventListener('click', handleOutsideClick); | ||
| } else { | ||
| document.removeEventListener('click', handleOutsideClick); | ||
| } |
Member
There was a problem hiding this comment.
Amazing work on removing your event listeners, it's really important practice
| const header = document.querySelector('.dropdown-header'); | ||
|
|
||
| if (!body.contains(event.target) && !header.contains(event.target)) { | ||
| wrapper.classList.remove('open'); |
Member
There was a problem hiding this comment.
Same thing in here, extract complex logic into a variable or a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated JSON file with extra details to match the design images in the design folder.