Almog Lavi #3
Open
Almog Lavi #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OfekSagiv
reviewed
Dec 19, 2025
Comment on lines
40
to
43
|
|
||
| squares[index] = isXNext ? "X" : "O"; | ||
| setSquares([...squares]); | ||
| setIsXNext(!isXNext); |
There was a problem hiding this comment.
You shouldn't modify the state object/array directly in React.
const nextSquares = [...squares];
nextSquares[index] = isXNext ? "X" : "O";
setSquares(nextSquares);
src/components/Game.tsx
Outdated
Comment on lines
10
to
38
| function handleSquareClick(index: number) { | ||
| // Temporary: no gameplay logic yet | ||
| console.log("Clicked square:", index); | ||
| if(calculateWinner()) |
There was a problem hiding this comment.
The logic is missing a check for whether a square is already occupied. Currently, a player can click an occupied square and overwrite its value.
src/components/Game.tsx
Outdated
Comment on lines
10
to
19
| const winnerCombination = [ | ||
| [0,1,2], | ||
| [3,4,5], | ||
| [6,7,8], | ||
| [0,4,8], | ||
| [6,4,2], | ||
| [0,3,6], | ||
| [2,5,8], | ||
| [1,4,7] | ||
| ] |
There was a problem hiding this comment.
This array is static. Currently, it is being re-allocated in memory every whenever the timer ticks).
Move this outside of the component function so it's initialized only once when the module loads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ulate winner