elad-abutbul

[Elad-Abutbul]

No description provided.

[Tamir198]

Good work overall, left you some commetns

[Tamir198]

This is good practice to use css variables

[Tamir198]

I would change this name into something like font-bold so in the future you will be able to change the value of this the selector name will remain relevant

[Tamir198]

If you give a button class button that a bit redundant, try to give this a better more meaningful name.

The name should indicate what the button should so like submit-button etc...

[Elad-Abutbul]

It’s a generic button class because there are two buttons — one in the signup page and one in the success page. They look the same, so there’s no reason to give them different class names.

[Tamir198]

you could give them the same class with more meaningful meaning like what they are doing
If you will add another button that will not looks like this then it can be confusing to have button class

[Tamir198]

This as well can be saved inside css variable

[Tamir198]

Remove those comments, they are not contributing to the understanding of the code

[Tamir198]

For the same reason above we can remove this comments

[Tamir198]

You should also check that the email is defined and not undefined or null

[Tamir198]

Its better to add class name and via css give this element styling of hidden or displayed

[Tamir198]

Same in here

[Tamir198]

In this function you can have early return and by doing so you will not need the else statement:

function toggleViews(toggle) {
  if (toggle === "signup") {
    signup.style.display = "flex";
    success.style.display = "none";
    return;
  }
  signup.style.display = "none";
  success.style.display = "flex";
}