Asaf Axelrod HTML CSS Practice #19
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,61 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <link rel="stylesheet" href="./styles/style.css" /> | ||
|
|
||
| <link rel="icon" type="image/png" sizes="32x32" href="./assets/images/favicon-32x32.png" /> | ||
|
|
||
| <title>Newsletter sign-up</title> | ||
| <script src="./script.js" defer></script> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div class="form-container"> | ||
| <div class="form-column" id="form-text"> | ||
| <h1 id="heading">Stay updated!</h1> | ||
|
|
||
| <p id="subheading"> | ||
|
|
||
| Join 60,000+ product managers receiving monthly updates on: | ||
| </p> | ||
| <ul> | ||
| <li>Product discovery and building what matters</li> | ||
| <li>Measuring to ensure updates are a success</li> | ||
| <li>And much more!</li> | ||
| </ul> | ||
|
|
||
| <label for="email" class="form-label">Email address</label> | ||
| <input type="email" id="email" name="email" placeholder="email@email.com" required /> | ||
|
|
||
| <button type="button" id="submit-button"> | ||
| Subscribe to monthly newsletter | ||
| </button> | ||
| </div> | ||
|
There was a problem hiding this comment. General note for "form-column" div: wrap the inner elements in individual divs for clearer structure and more consistent layout behavior |
||
|
|
||
| <div class="form-column"> | ||
| <div id="desktop-image"> | ||
| <img src="./assets/images/illustration-sign-up-desktop.svg" alt="Sign up illustration" /> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div id="success-card" class="hidden"> | ||
| <div class="success-content"> | ||
| <img src="./assets/images/icon-success.svg" alt="Success" id="success-icon" /> | ||
|
|
||
| <h1>Thanks for subscribing!</h1> | ||
|
|
||
| <p> | ||
| A confirmation email has been sent to | ||
| <strong id="user-email"></strong>. Please open it and click the button | ||
|
There was a problem hiding this comment. Use when the text has importance, urgency, or semantic emphasis |
||
| inside to confirm your subscription. | ||
| </p> | ||
|
|
||
| <button type="button" id="dismiss-button">Dismiss message</button> | ||
| </div> | ||
| </div> | ||
| </body> | ||
|
|
||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| document.addEventListener("DOMContentLoaded", () => { | ||
| const formContainer = document.querySelector(".form-container"); | ||
|
There was a problem hiding this comment. Good use of const. It’s a good idea to review why we use const/let instead of var in js |
||
| const successCard = document.getElementById("success-card"); | ||
|
|
||
| const emailInput = document.getElementById("email"); | ||
| const submitBtn = document.getElementById("submit-button"); | ||
| const dismissBtn = document.getElementById("dismiss-button"); | ||
| const userEmailSpot = document.getElementById("user-email"); | ||
|
|
||
| function isValidEmail(email) { | ||
| // simple email check – good enough for this challenge | ||
| return /\S+@\S+\.\S+/.test(email); | ||
| } | ||
|
|
||
| submitBtn.addEventListener("click", () => { | ||
|
There was a problem hiding this comment. This is a lambda function, worth reading up on how and when to use them |
||
| const email = emailInput.value.trim(); | ||
|
|
||
| if (!isValidEmail(email)) { | ||
| emailInput.style.borderColor = "red"; | ||
| return; | ||
| } | ||
|
|
||
| emailInput.style.borderColor = ""; // reset if previously red | ||
|
|
||
| // Insert email into success message | ||
| userEmailSpot.textContent = email; | ||
|
|
||
| // Hide form & show success | ||
| formContainer.classList.add("hidden"); | ||
| successCard.classList.remove("hidden"); | ||
| }); | ||
|
|
||
| dismissBtn.addEventListener("click", () => { | ||
| successCard.classList.add("hidden"); | ||
| formContainer.classList.remove("hidden"); | ||
|
|
||
| // reset form input | ||
| emailInput.value = ""; | ||
| emailInput.style.borderColor = ""; | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| /* | ||
| - Mobile: 375px | ||
| - Desktop: 1440px | ||
| */ | ||
|
|
||
| :root { | ||
|
There was a problem hiding this comment. Good use of CSS variables, they help keep the styling consistent, maintainable, and easier to update |
||
| font-family: "Roboto", sans-serif; | ||
| font-size: 16px; | ||
|
There was a problem hiding this comment. Consider using responsive units instead of px where possible. rem, em, or viewport units often give you more flexibility - read about it |
||
| --originalBlue800: hsl(234, 29%, 20%); | ||
| --originalBlue700: hsl(235, 18%, 26%); | ||
| --originalGrey: hsl(0, 0%, 58%); | ||
| --originalWhite: hsl(0, 0%, 100%); | ||
| --primaryRed: hsl(4, 100%, 67%); | ||
| } | ||
|
|
||
| *, | ||
| *::before, | ||
| *::after { | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| body { | ||
| margin: 0; | ||
| background-color: var(--originalBlue800); | ||
| width: 100vw; | ||
| height: 100vh; | ||
| overflow: hidden; | ||
| color: var(--originalBlue800); | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| .form-container { | ||
| background-color: var(--originalWhite); | ||
| width: 65%; | ||
| max-width: 900px; | ||
| border-radius: 25px; | ||
| display: flex; | ||
| flex-direction: row; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| .form-column { | ||
| flex: 1 1 0; | ||
| min-width: 0; | ||
|
|
||
| height: 100%; | ||
| padding: 2rem 1.5rem; | ||
|
|
||
|
|
||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| #form-text { | ||
| width: 100%; | ||
| margin-left: 1.3rem; | ||
| } | ||
|
|
||
| #form-text h1 { | ||
| font-size: 2.5rem; | ||
| line-height: 1.1; | ||
| margin-bottom: 1rem; | ||
| color: var(--originalBlue800); | ||
| } | ||
|
|
||
| #form-text>p { | ||
| font-size: 0.95rem; | ||
| color: var(--originalBlue700); | ||
| } | ||
|
|
||
| #form-text ul { | ||
| list-style: none; | ||
| padding-left: 0; | ||
| margin-bottom: 2rem; | ||
| } | ||
|
|
||
| #form-text ul li { | ||
| background-image: url("/newsletter-sign-up-with-success-message-main/assets/images/icon-list.svg"); | ||
| background-repeat: no-repeat; | ||
| background-position: 0 0.25rem; | ||
| background-size: 18px 18px; | ||
|
|
||
| padding-left: 1.6rem; | ||
| margin-bottom: 0.75rem; | ||
|
|
||
| font-size: 0.95rem; | ||
| line-height: 1.75; | ||
| color: var(--originalBlue800); | ||
| } | ||
|
|
||
| #form-text label { | ||
| display: block; | ||
| font-size: 0.75rem; | ||
| font-weight: 700; | ||
| margin-bottom: 0.4rem; | ||
| color: var(--originalBlue800); | ||
| } | ||
|
|
||
| #form-text input[type="email"] { | ||
| width: 100%; | ||
| padding: 0.9rem 1rem; | ||
| border-radius: 8px; | ||
|
There was a problem hiding this comment. why sometimes rem and sometimes px? be consistant |
||
| border: 1px solid hsl(231, 7%, 85%); | ||
| font-size: 0.9rem; | ||
| color: var(--originalBlue800); | ||
| margin-bottom: 1rem; | ||
| } | ||
|
|
||
| #form-text input[type="email"]::placeholder { | ||
| color: var(--originalGrey); | ||
| } | ||
|
|
||
| #form-text input[type="email"]:focus { | ||
| outline: none; | ||
| border-color: var(--originalBlue800); | ||
| } | ||
|
|
||
| button { | ||
| width: 100%; | ||
| padding: 0.9rem 1rem; | ||
| background: var(--originalBlue800); | ||
| color: var(--originalWhite); | ||
| border: none; | ||
| border-radius: 8px; | ||
| font: inherit; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| button:hover { | ||
| background: linear-gradient(to right, #ff5379, #fe693e); | ||
| box-shadow: inset 0 0 5px rgba(255, 255, 255, 0.3); | ||
| } | ||
|
|
||
| #desktop-image { | ||
| width: 100%; | ||
| height: 100%; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| #desktop-image img { | ||
| max-width: 100%; | ||
| object-fit: contain; | ||
| display: block; | ||
| } | ||
|
|
||
| .hidden { | ||
| display: none; | ||
| } | ||
|
|
||
| #success-card.hidden { | ||
| display: none; | ||
| } | ||
|
|
||
| #success-card { | ||
| background: var(--originalWhite); | ||
| width: 420px; | ||
| padding: 2.5rem; | ||
| border-radius: 25px; | ||
| box-shadow: 0 20px 40px rgba(0, 0, 0, 0.15); | ||
|
|
||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .success-content h1 { | ||
| color: var(--originalBlue800); | ||
| margin: 1.5rem 0 1rem; | ||
| font-size: 2rem; | ||
| } | ||
|
|
||
| .success-content p { | ||
| font-size: 0.95rem; | ||
| line-height: 1.4; | ||
| color: var(--originalBlue700); | ||
| margin-bottom: 1.5rem; | ||
| } | ||
|
|
||
| #success-icon { | ||
| width: 48px; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s generally better practice to apply styles using classes rather than relying solely on IDs. Classes are reusable, make the CSS more scalable, and avoid overly specific selectors