Css ex #22
Css ex #22
Conversation
ShirYahav
left a comment
ShirYahav
left a comment
There was a problem hiding this comment.
Good work, the code is clean! Follow the notes I gave you, and completing the JavaScript exercise will be a great preparation for the next lesson
| @@ -0,0 +1,126 @@ | |||
| body { | |||
| background-color: hsl(235, 18%, 26%); | |||
|
|
||
| @font-face { | ||
| font-family: "Roberto"; | ||
| src: url("./fonts/MyFont-Regular.ttf") format("truetype"); |
There was a problem hiding this comment.
Consider importing fonts in HTML ( in ) rather than only via CSS for better performance and compatibility
| height: 65%; | ||
| width: 55%; | ||
| background-color: white; | ||
| border-radius: 30px; |
There was a problem hiding this comment.
Dont use px, use responsive units like rem or em (read about the differences)
| display: none; | ||
| } | ||
|
|
||
| @media (max-width: 700px) { |
There was a problem hiding this comment.
love that you seperated the css files! good work
|
|
||
| @font-face { | ||
| font-family: "Roberto"; | ||
| src: url("./fonts/MyFont-Regular.ttf") format("truetype"); |
There was a problem hiding this comment.
Consider importing fonts in HTML ( in ) rather than only via CSS for better performance and compatibility
|
|
||
| .container { | ||
| display: flex; | ||
| width: 300px; |
There was a problem hiding this comment.
same note for this file as well: dont use px
There was a problem hiding this comment.
love the seperated files!! good practice!
2 participants
No description provided.