L1 hw #23
L1 hw #23
Conversation
idanpopovich8
left a comment
idanpopovich8
left a comment
There was a problem hiding this comment.
i left you some code review inside.
NICE WORK!!!
| top: 50%; | ||
| left: 50%; | ||
| transform: translate(-50%, -50%); | ||
| width: 800px; |
There was a problem hiding this comment.
It’s not recommended — and even considered incorrect — to use fixed pixel sizes for a div. If the user changes their screen size, the entire layout can break
try to use percentages or Vh and Vw
|
|
||
|
|
||
| .container img { | ||
| width: 95%; |
| } | ||
| .subbtn{ | ||
| display: flex; | ||
| width: 308px; |
| <!-- Sign-up form start --> | ||
|
|
||
| Stay updated! | ||
| <!--Stay updated! |
There was a problem hiding this comment.
we dont leave our comments inside. its better just to delete them : )
| </style> | ||
| </head> | ||
| <body> | ||
| <body style="background-color: hsl(234, 29%, 20%);"> |
There was a problem hiding this comment.
Its better to move the styling to the style.css file.
Keep a single tag and move the background-color into the CSS instead of using an inline style attribute.
| </div> | ||
| <p>Join 60,000+ product managers receiving monthly updates on:</p> | ||
| <div class="options"> | ||
| <img class="opimg"src="assets/images/icon-list.svg"> |
There was a problem hiding this comment.
Missing alt artibute inside the img label
| <img class="opimg"src="assets/images/icon-list.svg"> | ||
| <span class="data"> Product discovery and building what matters</span><br> | ||
| <img class="opimg"src="assets/images/icon-list.svg"> | ||
| <span class="data"> Product discovery and building what matters</span><br> |
There was a problem hiding this comment.
All three bullet points currently show the same text, and class name data its not a good name.
try to be more creative next time.
| <img class="opimg"src="assets/images/icon-list.svg"> | ||
| <span class="data"> Product discovery and building what matters</span><br> | ||
| <img class="opimg"src="assets/images/icon-list.svg"> | ||
| <span class="data"> Product discovery and building what matters</span><br> |
There was a problem hiding this comment.
Its not best practice to work with br label for spacing, Consider using marging it will fits good for your needs.
2 participants
No description provided.