chore: exercise 1 for Tamar matza #24
Conversation
idanpopovich8
left a comment
idanpopovich8
left a comment
There was a problem hiding this comment.
left you some comments about your work
GOOD JOB!!!
| </h1> | ||
| </div> | ||
| <div class="row2"> | ||
| <p1 class="befortext"> |
There was a problem hiding this comment.
I don’t recommend using p1 labels. It’s better to use standard p tags instead.
| </div> | ||
| <div class="row3"> | ||
| <div class="check1"> | ||
| <img src="assets\images\icon-list.svg" > |
There was a problem hiding this comment.
missing alt artibutes in the img lable
| Join 60,000+ product managers receiving monthly updates on: | ||
| </p1> | ||
| </div> | ||
| <div class="row3"> |
There was a problem hiding this comment.
Cosider to work with list (li) for more semantic code. i will recommend you to read about it
| measuring to ensure updates are a success | ||
| </div> | ||
| </div> | ||
| <div class="row5"> |
There was a problem hiding this comment.
Consider to dont work with numbers inside the class name e.g "row1,row2,text2" if you want to style each one diffrent give them a diffrent names and if you want to edit all the text so just call the class = "text" and in the style file you can edit them all as one
| <p class="emailtext"> | ||
| email adress</p> | ||
| <form class="email-form"> | ||
| <input type="email" name="email" placeholder="Email@company.com" required> |
There was a problem hiding this comment.
in here i recommend you to add id to the input so its will be acceessible to edit and work with.
|
|
||
|
|
||
| .center-rect { | ||
| background: hsl(234, 29%, 20%); |
There was a problem hiding this comment.
Consider to work with CSS varible instead it will make you code easier to read and more important easy to maintain.
| background: hsl(234, 29%, 20%); | ||
| padding-left: 15%; | ||
| padding-right: 15%; | ||
| padding-top: 7%; |
There was a problem hiding this comment.
In my opinion to much padding inside this block try to use general padding and after to tune but padding-top/right/down or left
| } | ||
|
|
||
|
|
||
| .picture img { |
There was a problem hiding this comment.
i dont know why to work with picture label
i never done that LOL : )
|
|
||
| text-align: center; | ||
| flex: 1; | ||
| flex-direction: row; |
There was a problem hiding this comment.
in here you are using flex-direction that its a flex property but the leftside contatiner is not display: flex so this line does nothing
| .rightside{ | ||
| column-gap: 30%; | ||
| justify-content: center; | ||
| align-items: center; |
There was a problem hiding this comment.
same as in the leftside container both of them are not display: flex so the justify-content and align-items are redundant
2 participants
Finished exercise.