Feature/after comments #30
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| const emailPattern = document.getElementById("email"); | ||
| const CCC = "#ccc" | ||
|
Member
There was a problem hiding this comment. There should not be colors in here, they should sit inside css variable object, also |
||
| const WHITE = "white" | ||
|
|
||
| emailPattern.addEventListener("input", function () { | ||
| const email = emailPattern.value; | ||
| const pattern = /^[^\s@]+@[^\s@]+\.[^\s@]+$/; | ||
| if (email === "") { | ||
| emailPattern.style.borderColor = "CCC"; | ||
|
Member
There was a problem hiding this comment. Never style via js, only from css and dynamic classes |
||
| emailPattern.style.backgroundColor = "WHITE"; | ||
| return; | ||
| } | ||
|
|
||
| if (pattern.test(email)) { | ||
| emailPattern.style.borderColor = "green"; | ||
| emailPattern.style.backgroundColor = "#e6ffe6"; | ||
| } else { | ||
| emailPattern.style.borderColor = "red"; | ||
| emailPattern.style.backgroundColor = "#ffe6e6"; | ||
| } | ||
| }); | ||
|
|
||
| emailPattern.addEventListener("blur", function () { | ||
| if (emailPattern.value.trim() === "") { | ||
| emailPattern.style.borderColor = "CCC"; | ||
| emailPattern.style.backgroundColor = "WHITE"; | ||
| } | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| @font-face { | ||
| font-family:Roboto ; | ||
| src: url(./assets/fonts/Roboto-Regular.ttf); | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
| body { | ||
| background-color: hsl(234, 29%, 20%); | ||
|
Member
There was a problem hiding this comment. bring the colors from css variables |
||
| height: 100vh; | ||
| margin: 0; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| font-family: 'Roboto'; | ||
| } | ||
|
|
||
|
|
||
| .container { | ||
| display: flex; | ||
| background: white; | ||
|
Member
There was a problem hiding this comment. Same here and for all of the similar places |
||
| width: 45%; | ||
| height: 55%; | ||
| border-radius: 25px; | ||
|
Member
There was a problem hiding this comment. Try not to mix different units, go with 1 |
||
| overflow: hidden; | ||
| box-shadow: 0 10px 35px rgba(0,0,0,0.25); | ||
| } | ||
|
|
||
| #left-side { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| padding: 50px; | ||
| width: 43%; | ||
| height: auto; | ||
|
Member
There was a problem hiding this comment. Do you really need this? will it have any effect? |
||
| margin-left:15px; | ||
|
|
||
|
|
||
| } | ||
|
|
||
| #left-side h1 { | ||
|
Member
There was a problem hiding this comment. Can you think of a better name than left side? what if this will not be on the left side in the future? |
||
| font-size: 50px; | ||
| margin-bottom: 20px; | ||
| } | ||
|
|
||
| #left-side p { | ||
| font-size: 14px; | ||
| margin-bottom: 20px; | ||
| line-height:1.45; | ||
| } | ||
| #left-side ul { | ||
| padding: 0; | ||
| margin: 0 0 30px 0; | ||
| } | ||
|
|
||
| #left-side li { | ||
| list-style: none; | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 12px; | ||
| margin-bottom: 12px; | ||
| font-size: 15px; | ||
| } | ||
|
|
||
| #left-side img { | ||
| width: 20px; | ||
| } | ||
|
|
||
| label { | ||
| font-size: 12px; | ||
| font-weight: bold; | ||
| margin-bottom: 8px; | ||
| } | ||
|
|
||
| input { | ||
| padding: 12px; | ||
| border-radius: 8px; | ||
| border: 1px solid #ccc; | ||
| width: 95%; | ||
| font-size: 14px; | ||
| margin-bottom: 15px; | ||
| transition: 0.3s ease; | ||
| } | ||
|
|
||
| button { | ||
| background-color: hsl(234, 29%, 20%); | ||
| color: white; | ||
| padding: 14px; | ||
| border-radius: 8px; | ||
| border: none; | ||
| font-size: 14px; | ||
| cursor: pointer; | ||
| width: 103%; | ||
| } | ||
|
|
||
| button:hover { | ||
| background-color: hsl(4, 100%, 67%); | ||
| } | ||
|
|
||
|
|
||
| #right-side { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| background: linear-gradient(135deg, #ff4664, #ff8f40); | ||
| width: 390px; | ||
| margin: 20px 20px 20px 0; | ||
| border-radius: 15px; | ||
| } | ||
|
|
||
| #right-side img { | ||
| width: 100%; | ||
| height: auto; | ||
|
|
||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,49 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Asher Pe'er</title> | ||
| <link rel="stylesheet" href="index.css"> | ||
| <link rel="font" href="https://fonts.google.com/specimen/Roboto"> | ||
| </head> | ||
|
|
||
|
|
||
|
|
||
|
|
||
| <body> | ||
|
|
||
| <div class="container"> | ||
| <div id="left-side"> | ||
| <h1>Stay update!</h1> | ||
| <p> | ||
| Join 60,000+ product managers receiving monthly updates on: | ||
| </p> | ||
|
|
||
| <ul> | ||
| <li><img src="assets/images/icon-list.svg" alt="">Product discovery and building what matters</li> | ||
|
Member
There was a problem hiding this comment. Empty alt means nothing in terms of accessibility |
||
| <li><img src="assets/images/icon-list.svg" alt="">Measuring to ensure updates are a success</li> | ||
| <li> <img src="assets/images/icon-list.svg" alt="">And much more!</li> | ||
| </ul> | ||
|
|
||
| <label for="email">Email address</label> | ||
| <input type="email" id="email" placeholder="email@company.com"> | ||
|
|
||
| <form> | ||
| <button type="submit">Subscribe to monthly newsletter</button> | ||
| </form> | ||
|
|
||
|
|
||
| </div> | ||
|
|
||
| <div id="right-side"> | ||
| <img src="assets/images/illustration-sign-up-desktop.svg" alt=""> | ||
| </div> | ||
| </div> | ||
|
|
||
|
|
||
| <script src="email.js"></script> | ||
| </body> | ||
|
|
||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the patterns but the element