or_chen #9
Open
or_chen #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
reviewed
Dec 11, 2025
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Hey looks good overall, one thing i noticed is that you are using explicitly return inside arrow functions.
Meaning:
const somethig = () => {
return "value"
}For simple function you can really make then 1 liner:
const somethig = () => "value"I added a comment about this.
This is just opinion, you are not wrong
| ) /* : add return types */ { | ||
| return []; | ||
| function getAvailableProducts(store: Store): Product[] { | ||
| return store.products.filter((product) => { return product.inStock }) |
Member
There was a problem hiding this comment.
For such short function you could also use return store.products.filter((product) => product.stock
| cart :number[], | ||
| ) :number { | ||
| let total = 0 | ||
| store.products.forEach((product) => { |
Member
There was a problem hiding this comment.
Read about reduce function it can help in here
Author
There was a problem hiding this comment.
i used forEach because this was the requirement
Member
There was a problem hiding this comment.
And you did a great job, just telling you that js provides not only forEach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test