Update theme generator to use config values for colors - #8
Conversation
|
Thanks @ruanpepe — you found a real bug, and the diagnosis was right. Confirmed by rendering the component both ways: <!-- value="#343a40" -->
<input type="color" name="sidebar_color" value="#0d6efd" class="form-control form-control-color" value="#343a40">
<!-- default="#343a40" -->
<input type="color" name="sidebar_color" value="#343a40" class="form-control form-control-color">
Digging into it turned up the reason the page needed that fallback in the first place: So rather than merge this and leave the page half-honest, I've landed it as #9, which includes your fix and makes the four keys real — they're now injected into the layout head as CSS custom-property overrides, so the generator's output actually works. You're credited as co-author on the commit. Closing in favour of #9. Thanks for the report and for iterating on it. |
Description
Checklist
composer checkpasses locally (Pint + PHPStan + PHPUnit)docs/if behaviour or APIs changed (they are served in-app at/docs)CHANGELOG.mdentry under [Unreleased]resources/lang/