Conversation
| @@ -0,0 +1,167 @@ | |||
| // | |||
There was a problem hiding this comment.
This folder (Sources/CombineCocoa/Interception) is actually a port of ReactiveCocoa code, so maybe it is worth mentioning them in Readme/Credits/Acknowledgements
|
Plus as you already saw that I made https://github.com/capturecontext/combine-interception, which implements this feature and will allow you to plug-in this feature locally Pros of adding it to CombineCocoa:
Cons:
I'm a naming nerd so I have my own combine extensions (wip), but the initial reason I made it, is at least to import gh/combine-extensions instead of gh/CombineExt 🤡 However I have another wip project combine-cocoa-navigation, and for now it's (my) combine-extensions-dependent, but if we keep this feature as a separate package I can remove my dependency and this navigation package will be available for those who use I'm not sure if @freak4pc will be down to depend on my lib, if not, maybe it is worth to create a separate repo in this org anyway to transfer https://github.com/capturecontext/combine-interception to CombineCommunity |
Closes #50
Full credit to @maximkrouk. I pulled his changes and rewound them onto the current master build with some tiny tweaks - notably retaining
Runtimenaming for the framework, and keeping "Interception" related code inside CombineCocoa's main directory.