Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughBumped multiple comfyui-workflow-templates packages across compiled requirements, added explicit dependency Changes
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
## Summary - Bump desktop package version to `0.8.17` on top of ComfyUI bump stack. ## Testing - `yarn format` - `yarn lint` - `yarn typecheck` ## Merge after - Merge after: #1644
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41bbccd14c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
assets/requirements/macos.compiled
Outdated
| # torchvision | ||
| # from https://pypi.org/simple | ||
| torchaudio==2.10.0 | ||
| torchaudio==2.9.1 |
There was a problem hiding this comment.
Keep macOS torchaudio pin in sync with torch
The macOS compiled lock now pins torch==2.10.0 but torchaudio==2.9.1, and this file is installed directly by installRequirements() (src/virtualEnvironment.ts) during normal setup, so users can end up with a mixed PyTorch stack. In practice, torch ecosystem packages are version-coupled enough that cross-minor combinations frequently fail at install or import time (especially when ComfyUI loads audio nodes), so this should be pinned to a matching torchaudio release (or torch downgraded consistently).
Useful? React with 👍 / 👎.
Summary
0.16.3to0.16.4.scripts/core-requirements.patchto match upstreamrequirements.txtcontext forv0.16.4.assets/requirements/*.compiledby rerunningyarn make:assetsandrecompile_from_headers.sh.Testing
yarn formatyarn lintyarn typecheckyarn test:unitFollow-up
Summary by CodeRabbit