Skip to content

fix: verify marketplace nft ownership#522

Closed
dangelo352 wants to merge 1 commit into
Commitlabs-Org:masterfrom
dangelo352:security/marketplace-nft-ownership-488
Closed

fix: verify marketplace nft ownership#522
dangelo352 wants to merge 1 commit into
Commitlabs-Org:masterfrom
dangelo352:security/marketplace-nft-ownership-488

Conversation

@dangelo352

Copy link
Copy Markdown

Summary

  • verify marketplace list_nft and start_auction sellers own an active NFT via the configured NFT contract
  • revalidate existing listing/auction seller ownership before accepting make_offer on those positions
  • expose get_nft_contract for visibility and test setup
  • add mock-NFT coverage for owned, unowned, inactive, and stale-owner listing/auction/offer paths
  • update marketplace lifecycle and security docs

Closes #488.

Validation

  • CARGO_TARGET_DIR=/tmp/commitlabs-marketplace-owner-target cargo test -p commitment-marketplace "rejects_" -- --nocapture
  • CARGO_TARGET_DIR=/tmp/commitlabs-marketplace-owner-target cargo test -p commitment-marketplace -- --nocapture
  • git diff --check

Notes: the marketplace suite passes with existing warnings for an unused seller variable and unused set_contract_reentrancy_guard helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cross-contract NFT ownership verification to commitment_marketplace::list_nft

2 participants