test: cover commitmentHistory service aggregation and ordering#1095
Open
Sendi0011 wants to merge 1 commit into
Open
test: cover commitmentHistory service aggregation and ordering#1095Sendi0011 wants to merge 1 commit into
Sendi0011 wants to merge 1 commit into
Conversation
- Add service-level unit test for getCommitmentHistory at tests/lib/backend/commitmentHistory.service.test.ts - Mock getMockData to verify created event shape - Assert one event per attestation, filtered by commitmentId - Assert correct terminal event (early_exit / settlement) based on status, and none for ACTIVE/VIOLATED/UNKNOWN - Verify chronological ordering ascending by occurredAt, including out-of-order source data and interleaved terminal events - Cover edge cases: no attestations, active/early_exit/settled, missing createdAt (epoch fallback), missing kind (defaults to 'unknown'), undefined complianceScore/violation Closes Commitlabs-Org#759
|
@Sendi0011 is attempting to deploy a commit to the 1nonly's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
this one comes in massively diverged, the merge wants to delete most of the source tree and tests. looks like it's built off a very old base, can you rebase onto current master and repush? ping us in https://discord.gg/WV7tdYkJk if you want a hand |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #759
Type of Change
Please delete options that are not relevant.
Checklist
Please review the Developer Guide before checking the items below:
DEVELOPER_GUIDE.md,README.md, or inline files).pnpm run test:coverageornpm run test:coverage).pnpm lintornpm run lint) and fixed all error diagnostics.Visual Changes (if applicable)
Please add screenshots, screen recordings, or GIFs showcasing the user interface changes.
Join the Discussion
Need help or want to chat? Join our CommitLabs Discord server.