Skip to content

Group input refactor#389

Open
Gunoshozo wants to merge 3 commits intomasterfrom
group-input-refactor
Open

Group input refactor#389
Gunoshozo wants to merge 3 commits intomasterfrom
group-input-refactor

Conversation

@Gunoshozo
Copy link
Contributor

Group Input Refactor

  • Decouple Update and UpdateInput for Group
  • Add separate UpdateInput for relevant groups
  • Fix CHLCC Music Menu out of bounds hover
  • Use Enum state instead of boolean

- Add separate UpdateInput for relevant groups
- Fix CHLCC Music Menu out of bounds hover
@Gunoshozo Gunoshozo force-pushed the group-input-refactor branch from 66759a7 to 5a21bcf Compare February 14, 2026 08:15
@Gunoshozo Gunoshozo marked this pull request as ready for review February 14, 2026 09:28
- Use Enum state instead of boolean
@Gunoshozo Gunoshozo force-pushed the group-input-refactor branch from 5a21bcf to a3d9002 Compare February 14, 2026 11:33
Copy link
Member

@PringlesGang PringlesGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groups that still need to get an UpdateInput call:

  • src/games/darling/sysmesbox.cpp ChoiceItems
  • src/games/mo6tw/sysmesbox.cpp ChoiceItems
  • src/games/mo6tw/titlemenu.cpp ContinueItems
  • src/games/mo6tw/titlemenu.cpp SystemItems
  • src/games/mo6tw/titlemenu.cpp ExtraStoryItems
  • src/games/mo6tw/titlemenu.cpp MemoriesItems

- Add missing UpdateInput calls
- Use better name for new Enum field
@Gunoshozo Gunoshozo force-pushed the group-input-refactor branch from 08390d9 to e9eba08 Compare February 15, 2026 20:13
@Gunoshozo Gunoshozo requested a review from KKhanhH February 15, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Out of bounds Group items can request a pointer cursor and are hoverable

2 participants