Merged
Conversation
Contributor
Gunoshozo
commented
Feb 15, 2026
Gunoshozo
commented
- Use proper Ids for music menu
- Implement music menu Init logic for CHLCC (BGM flags codepend on other BGM flags + on ending flags)
Closed
PringlesGang
approved these changes
Feb 15, 2026
src/games/chlcc/musicmenu.cpp
Outdated
Comment on lines
152
to
157
| const int endingFlags[7] = {SF_CLR_RIMI, SF_CLR_NANAMI, SF_CLR_YUA, | ||
| SF_CLR_MIA, SF_CLR_SENA, SF_CLR_KOZUE, | ||
| SF_CLR_SEIRA}; | ||
| const bool gotRequiredEndings = | ||
| std::all_of(std::begin(endingFlags), std::end(endingFlags), | ||
| [](int flag) { return GetFlag(flag); }); |
Member
There was a problem hiding this comment.
const std::array<int, 7> endingFlags = [...];
const bool gotRequiredEndings = std::ranges::all_of(endingFlags,
[](int flag) { return GetFlag(flag); });
Gunoshozo
force-pushed
the
bgm-unlocks
branch
2 times, most recently
from
3825b37 to
9e39e06
Compare
- Changed bgm checking to work with internal flags, not arbitrary ids. - Add MusicMenu::Init with flag unlocks logic - implement InstSoundMenu "MusicInit" branch Co-authored-by: Quessian-Phaedrus-Sternabite <56981027+quessian-phaedrus-sternabite@users.noreply.github.com>
Gunoshozo
force-pushed
the
bgm-unlocks
branch
from
9e39e06 to
a40eb06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.