[DialoguePage Refactor Step 2] Nametag refactor #395
Draft
PringlesGang wants to merge 3 commits intomasterfrom
Draft
[DialoguePage Refactor Step 2] Nametag refactor #395PringlesGang wants to merge 3 commits intomasterfrom
PringlesGang wants to merge 3 commits intomasterfrom
Conversation
PringlesGang
force-pushed
the
nametag-refactor
branch
5 times, most recently
from
8f03e4b to
2a7f915
Compare
Enorovan
changed the title
PringlesGang
force-pushed
the
nametag-refactor
branch
from
2a7f915 to
3bcd3c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the whole nametag system for more extensibility, maintainability, and readability
Makes use of an abstract base class approach for the
NametagDisplaySimilarly overhauls the
DialogueBoxclass to make better use of the new nametag systemAdds ownership from
DialoguePage->DialogueBox->NametagDisplay, as eachDialoguePagein the MAGES. engine maintains its own textbox state(I am aware this ownership unnecessarily allocated
DialogueBoxes for every backlog and tip entry. I pinky-promise I will finally separate these two fromDialoguePagenext refactor!)src/hud/nametagdisplayandsrc/hud/dialogueboxhave been completely rewritten, so I suggest reviewing those as effectively "new files," instead of looking at the git diff