Skip to content

FCOM-338 Add possibility to add custom JWT headers in Frends.Community.OAuth#9

Open
palssve wants to merge 2 commits intoCommunityHiQ:masterfrom
palssve:master
Open

FCOM-338 Add possibility to add custom JWT headers in Frends.Community.OAuth#9
palssve wants to merge 2 commits intoCommunityHiQ:masterfrom
palssve:master

Conversation

@palssve
Copy link

@palssve palssve commented May 13, 2022

Sorry about the possible CR <-> LF issues ( pull request seems to contain more data than is changed )

Added tests for this too,

Made this change because a customer requested it.

@palssve palssve requested a review from Svenskapojkarna May 13, 2022 11:33
@palssve
Copy link
Author

palssve commented May 17, 2022

Actually we managed to get JWT auth to work with customer ( enersense ) without using the "kid" header in the JWT token,
This pull request could therefore be rejected, we don't need it and having the "kid" header in JWT is not so important to me anymore...and the implementation seems to be written so that it requires the x5t header to be set... so that is not a good thing either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant