Skip to content

Prefer genesis for model downloads, fall back to Zenodo #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RalfG merged 1 commit into from
Feb 10, 2026
Merged

Prefer genesis for model downloads, fall back to Zenodo #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_and_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-13, macos-14] # macos-13 for intel, macos-14 for apple silicon
os: [ubuntu-latest, windows-latest, macos-latest, macos-15-intel] # macos-latest for ARM, macos-15-intel for x86_64; see https://github.com/actions/runner-images/issues/13046
steps:
- uses: actions/checkout@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion ms2pip/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# isort: skip_file
"""MS2PIP: Accurate and versatile peptide fragmentation spectrum prediction."""

__version__ = "4.1.1"
__version__ = "4.1.2"

from warnings import filterwarnings

Expand Down
6 changes: 5 additions & 1 deletion ms2pip/_utils/xgb_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,11 @@ def _download_model(model, model_hash, model_dir):
filename = os.path.join(model_dir, model)

logger.info(f"Downloading {model} to {filename}...")
urllib.request.urlretrieve(f"https://zenodo.org/records/13270668/files/{model}", filename)
try:
urllib.request.urlretrieve(f"https://genesis.ugent.be/uvpublicdata/ms2pip/{model}", filename)
except Exception:
logger.warning("Falling back to Zenodo for model downloads.")
urllib.request.urlretrieve(f"https://zenodo.org/records/13270668/files/{model}", filename)
if not _check_model_integrity(filename, model_hash):
raise InvalidXGBoostModelError()

Expand Down