Skip to content

Comments

fix logging for spectral library prediction#257

Merged
RalfG merged 2 commits intoCompOmics:releasesfrom
paretje:hotfix/logging
Feb 10, 2026
Merged

fix logging for spectral library prediction#257
RalfG merged 2 commits intoCompOmics:releasesfrom
paretje:hotfix/logging

Conversation

@paretje
Copy link
Contributor

@paretje paretje commented Feb 10, 2026

  • drop disabling the logging during spectral library prediction
  • fix formatting of logging output by dropping the console argument, making sure logging and progress tracking use the same global console object
  • drop our console object and use rich.print instead

@paretje
don't disable logging
7ed80dd 
Don't disable logging during spectral library prediction. Remove console
parameter to RichHandler, and use global console instance, as used by
`track`.
@paretje
drop console instance and use rich.print
18b204c
@paretje paretje requested a review from RalfG February 10, 2026 12:54
@RalfG RalfG merged commit 0aca6b3 into CompOmics:releases Feb 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfG RalfG RalfG approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paretje @RalfG