CMP-4293: updated imagePullPolicy to default of IfNotPresent

[vickeybrown]

We need to change the default imagePullPolicy from Always to IfNotPresent as it's causing issues with docker registry.

Closes CMP-4293

[openshift-ci-robot]

@vickeybrown: This pull request references CMP-4293 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "5.0.0" version, but no target version was set.

Details

In response to this:

We need to change the default imagePullPolicy from Always to IfNotPresent as it's causing issues with docker registry.

Closes CMP-4293

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[github-actions]

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1208-2e2042f5dcf4abf062d2850dd441a4eeddb2960d

[vickeybrown]

/retest

[taimurhafeez]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: taimurhafeez, vickeybrown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [taimurhafeez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sebrandon1]

I don't think this is a good idea since the images being used are hardcoded to latest currently. I have a PR open here to pin the images to the actual "latest" available tags in the registry: #1196

Also, the current latest version of the image(s) are not being pushed correctly to the ghcr repo: ComplianceAsCode/content#14681

[yuumasato]

When we release downstream, these images are pinned in the CSV in the Bundle Image:

 oc get csv -oyaml | grep -i -A1 related_image
                  - name: RELATED_IMAGE_OPENSCAP
                    value: registry.redhat.io/compliance/openshift-compliance-openscap-rhel8@sha256:427077038c18956989ab928cdc7338f70b2fc7cf4c6980547c9a0f88db00d0ca
                  - name: RELATED_IMAGE_OPERATOR
                    value: registry.redhat.io/compliance/openshift-compliance-rhel8-operator@sha256:76b0efb50f8812ac5ff6fb110625fae4aa0f6f9c6b16d4a659735c598dd5974c
                  - name: RELATED_IMAGE_PROFILE
                    value: registry.redhat.io/compliance/openshift-compliance-content-rhel8@sha256:1c58fd6824b86368e74ba9868d77cdb7cae800e4d44a0f72297547019139b13d

[yuumasato]

I don't think we should be pinning the images on the development branch, but I agree we should pin then at the moment of release. In the release-1.9 branch for example.

[yuumasato]

/test e2e-aws-parallel-arm

[openshift-ci]

@vickeybrown: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-rosa	2e2042f	link	true	/test e2e-rosa
ci/prow/e2e-aws-parallel-arm	2e2042f	link	true	/test e2e-aws-parallel-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.