Handle unused error from RowsAffected in RecordUpdaterSetStatus#109
Open
Mab879 wants to merge 1 commit into
Open
Handle unused error from RowsAffected in RecordUpdaterSetStatus#109Mab879 wants to merge 1 commit into
Mab879 wants to merge 1 commit into
Conversation
The error returned by tag.RowsAffected() was silently ignored. Log it as a warning when it occurs, since the transaction has already been committed and the operation itself succeeded. While this error will most likely not happen we should handle it just in case. Claude Opus 4.6 was used in part of creating this issue. Fixes finding from CodeQL quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error returned by tag.RowsAffected() was silently ignored. Log it as a warning when it occurs, since the transaction has already been committed and the operation itself succeeded.
While this error will most likely not happen we should handle it just in case.
Claude Opus 4.6 was used in part of creating this issue.
Fixes finding from CodeQL quality.