Skip to content

use mainline packages for ibc and 08-wasm #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
faddat wants to merge 11 commits into
base: release/v7.0.x
Choose a base branch
from
Draft

use mainline packages for ibc and 08-wasm #374

faddat wants to merge 11 commits into from

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Dec 27, 2023 •
edited
Loading

This PR:

  • upgrades alliance (I suspect it still does stuff though that ought to be impossible)
    • reasoning: I've seen locally synced nodes get an error from it. We can also just delete the storekey and remove the module fully. Both paths are totally acceptable.
  • upgrades ibc-go
  • upgrades 08-wasm
  • uses mainline interchaintest
    • interchaintest has been ugpraded to support the new wasm client, and so we no longer need to use a fork.

@faddat faddat mentioned this pull request Dec 27, 2023
Open
18 tasks
faddat
faddat commented Dec 27, 2023
View reviewed changes
app/ibctesting/config.go
func (tmcfg *TendermintConfig) GetClientType() string {
if tmcfg.IsWasmClient {
return exported.Wasm
return exported.ModuleName
Copy link
Contributor Author

@faddat faddat Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels wrong...

faddat
faddat commented Dec 27, 2023
View reviewed changes
app/ibctesting/endpoint.go
consensusState = &wasmtypes.ConsensusState{
Data: wasmConsensusState,
Timestamp: tmConsensusState.GetTimestamp(),
Data: wasmConsensusState,
Copy link
Contributor Author

@faddat faddat Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration hotspot

faddat
faddat commented Dec 27, 2023
View reviewed changes
faddat
faddat commented Dec 27, 2023
View reviewed changes
x/transfermiddleware/ibc_ante_test.go

msg := wasmtypes.NewMsgPushNewWasmCode(govAuthorityAddress, wasmContract)
response, err := suite.wasmKeeper.PushNewWasmCode(suite.ctx, msg)
msg := wasmtypes.NewMsgStoreCode(govAuthorityAddress, wasmContract)
Copy link
Contributor Author

@faddat faddat Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this is right

@faddat faddat mentioned this pull request Dec 27, 2023
Merged
@dzmitry-lahoda
Copy link
Contributor

dzmitry-lahoda commented Dec 29, 2023

@faddat please take a look to merge into #387

@blasrodri nobody knows better wasm side of wasm08, this seems needs some wasm engine to setup and options provided.

@dzmitry-lahoda
feat: wasmd clean up and updates (#387)
15038af 
* chore: edd easy shell into devenv

* chore: use non deprecated name

* one more deprecated

* fixes of params
@faddat
Copy link
Contributor Author

faddat commented Dec 29, 2023

@dzmitry-lahoda I've checked it out, and it was quite helpful thank you!

Merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@faddat @dzmitry-lahoda @crodriguezvega