Skip to content

Replace rememberPluginVersion with ValkyrieBuildConfig due Internal API usage #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egorikftp merged 1 commit into from
May 29, 2026
Merged

Replace rememberPluginVersion with ValkyrieBuildConfig due Internal API usage #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tools/idea-plugin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,18 @@ plugins {
alias(libs.plugins.jetbrains.intellij)
alias(libs.plugins.jetbrains.changelog)
alias(libs.plugins.kotlin.serialization)
alias(libs.plugins.buildconfig)
}

group = "io.github.composegears"
version = ideaPluginVersions.versions.idea.plugin.version.get()

buildConfig {
packageName = "io.github.composegears.valkyrie"
className = "ValkyrieBuildConfig"
buildConfigField("VERSION", ideaPluginVersions.versions.idea.plugin.version.get())
}

configurations.getByName("implementation") {
exclude(group = "org.jetbrains.kotlin", module = "kotlin-reflect")
exclude(group = "org.jetbrains.kotlin", module = "kotlin-stdlib")
Expand Down
4 changes: 2 additions & 2 deletions ...dea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/intro/IntroScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import com.composegears.tiamat.compose.navDestination
import com.composegears.tiamat.compose.navigate
import io.github.composegears.valkyrie.FeatureFlag.ICON_EDITOR_FEATURE_ENABLED
import io.github.composegears.valkyrie.FeatureFlag.KT_TO_SVG_ENABLED
import io.github.composegears.valkyrie.ValkyrieBuildConfig
import io.github.composegears.valkyrie.jewel.HorizontalDivider
import io.github.composegears.valkyrie.jewel.InfoCard
import io.github.composegears.valkyrie.jewel.SettingsAction
Expand All @@ -34,7 +35,6 @@ import io.github.composegears.valkyrie.sdk.compose.icons.outlined.SvgXml
import io.github.composegears.valkyrie.sdk.shared.ValkyrieMode
import io.github.composegears.valkyrie.sdk.shared.ValkyrieTool
import io.github.composegears.valkyrie.ui.screen.editor.EditorSelectScreen
import io.github.composegears.valkyrie.ui.screen.intro.util.rememberPluginVersion
import io.github.composegears.valkyrie.ui.screen.mode.iconpack.IconPackModeScreen
import io.github.composegears.valkyrie.ui.screen.mode.simple.picker.SimplePickerScreen
import io.github.composegears.valkyrie.ui.screen.settings.SettingsScreen
Expand Down Expand Up @@ -160,7 +160,7 @@ private fun IntroScreenUI(
.align(Alignment.BottomEnd)
.padding(end = 16.dp, bottom = 8.dp),
style = JewelTheme.typography.small,
text = rememberPluginVersion(),
text = ValkyrieBuildConfig.VERSION,
maxLines = 1,
)
}
Expand Down
17 changes: 0 additions & 17 deletions ...gin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/intro/util/PluginVersion.kt
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...tlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/about/AboutSettingsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import com.composegears.tiamat.compose.navDestination
import io.github.composegears.valkyrie.ValkyrieBuildConfig
import io.github.composegears.valkyrie.jewel.HorizontalDivider
import io.github.composegears.valkyrie.jewel.settings.GroupSpacing
import io.github.composegears.valkyrie.jewel.tooling.PreviewTheme
import io.github.composegears.valkyrie.sdk.compose.foundation.layout.CenterVerticalRow
import io.github.composegears.valkyrie.sdk.compose.foundation.layout.Spacer
import io.github.composegears.valkyrie.sdk.compose.icons.ValkyrieIcons
import io.github.composegears.valkyrie.sdk.compose.icons.colored.PluginIcon
import io.github.composegears.valkyrie.ui.screen.intro.util.rememberPluginVersion
import io.github.composegears.valkyrie.util.stringResource
import org.jetbrains.compose.ui.tooling.preview.Preview
import org.jetbrains.jewel.foundation.theme.JewelTheme
Expand Down Expand Up @@ -46,7 +46,7 @@ private fun AboutSettingsUi() {
style = JewelTheme.typography.h3TextStyle,
)
InfoText(
text = rememberPluginVersion(),
text = ValkyrieBuildConfig.VERSION,
style = JewelTheme.typography.small,
)
}
Expand Down