Skip to content

[HOLD — deploy-gated] GitHub in-app OAuth + Universal Links (iOS A1/A2) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adron wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[HOLD — deploy-gated] GitHub in-app OAuth + Universal Links (iOS A1/A2) #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions InterlinedList/InterlinedList.entitlements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,9 @@
<dict>
<key>aps-environment</key>
<string>development</string>
<key>com.apple.developer.associated-domains</key>
<array>
<string>applinks:interlinedlist.com</string>
</array>
</dict>
</plist>
9 changes: 5 additions & 4 deletions InterlinedList/InterlinedListApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,11 @@ struct InterlinedListApp: App {
}
}

// TODO(A2): Universal Links (a tapped https://interlinedlist.com link opening the
// app directly) need the backend to publish apple-app-site-association plus the
// Associated Domains entitlement. `parse` already accepts https permalinks, so
// onOpenURL will route them once that server asset ships.
// A2: Universal Links (a tapped https://interlinedlist.com link opening the app
// directly). The Associated Domains entitlement (applinks:interlinedlist.com) is now
// in place and `parse` already accepts https permalinks, so onOpenURL will route them
// once the backend publishes apple-app-site-association and the Associated Domains
// capability is enabled for the App ID / provisioning profile.
private func handleDeepLink(_ url: URL) {
// OAuth callbacks are captured by ASWebAuthenticationSession itself; the
// app-level handler is a fallback for a torn-down session (safe to ignore).
Expand Down
11 changes: 5 additions & 6 deletions InterlinedList/Services/OAuthCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,11 @@ enum OAuthProvider: String, CaseIterable {
}

/// Whether this provider's OAuth callback supports the native custom-scheme
/// token handoff. GitHub's callback has no mobile branch — it sets a web
/// session cookie and redirects to /dashboard, so it never returns
/// `interlinedlist://oauth/callback?token=…` and can't complete inside
/// `ASWebAuthenticationSession`. Hidden until the backend adds that branch.
/// (Backend auth contract — Open Dependency #1.)
var supportsNativeAuth: Bool { self != .github }
/// token handoff. All providers now return `interlinedlist://oauth/callback?token=…`
/// and complete inside `ASWebAuthenticationSession`. GitHub is enabled pending
/// the backend A1 deploy that adds its mobile branch; until that ships the
/// GitHub button will 401. (Backend auth contract — A1.)
var supportsNativeAuth: Bool { true }
}

enum OAuthError: Error {
Expand Down