Allow hiding in progress results #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I realised there's no CI, so rebasing atop gmt and mod tidy |
mxmeinhold
force-pushed
the
mom/hide-progress
branch
2 times, most recently
from
f4f369f to
e2c3eac
Compare
Author
|
@tallen42 I'm gonna consider this ready for review, and switch to another branch before I go down another 3 rabbit holes |
mxmeinhold
changed the title
BigSpaceships
approved these changes
Dec 2, 2025
Contributor
BigSpaceships
left a comment
BigSpaceships
left a comment
There was a problem hiding this comment.
LGTM tested:
- hidden votes stay hidden
- can hide votes after creation or before
- People who should vote can vote (I think)
- Dev evals overrides works
- alum active override works I think but also you're not gonna pass gatekeep so maybe that should just be an "alums can vote" override
- reveal button is gone
Author
|
I'm going to rebase atop dev to check for conflicts, and squash down my fixups before merging |
this replaces the current hide functionality
Polls that are hidden really shouldn't be revealed
mxmeinhold
force-pushed
the
mom/hide-progress
branch
from
bd3ce79 to
321f2e1
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Separate the concept of a hidden poll and a poll that should have secret votes. This allows automatically hiding results till the poll is complete
This starts work on #7, but isn't a full featured solution
Main Objectives
Bonuses