refactor(pumpkin-core): Only initialise arena allocator when first nogood is inserted + decrease memory limit#366
Merged
maartenflippo merged 2 commits intomainfrom Feb 11, 2026
Conversation
maartenflippo
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to allocate the memory of the arena allocator as soon as it was created. This led to unnecessary overhead when posting the FlatZinc constraints and/or when using a resolver that does not use nogoods.
Additionally, we used to preallocate space for 250.000.000$\frac{1.000 \times 1.000.000}{4} = 250.000.000$ ); this PR reduces the default from 1000MB to 25MB, resulting in 12.500.000 million
PredicateIds (i.e., 1000MB for 4 byte structs:PredicateIds being preallocated.