Open
Conversation
|
@sergiou87, thanks for the pull request. We are not going to merge it at the moment, because there is a few things to think about. Please feel free to discuss the improvement here: #136 |
Contributor
|
@sergiou87 Thank you for the pull request and using the sdk. If you have any issues with connect sdk in the future or if you would like to provide feedback or feature requests you can contact us at support@connectsdk.com . Looking forward to hearing from you. |
jonghenhan
force-pushed
the
master
branch
3 times, most recently
from
c72ba9f to
c358a34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request depends on this one: ConnectSDK/Connect-SDK-iOS-Core#13
The problem is our project depends on
GCDWebServerpod, with theWebDavsub-pod, and having these files also inConnectSDKresults in build errors because of having duplicated definitions ofGCDWebServerclasses.So I have deleted these files here and added
GCDWebServeras a pod dependency in theConnectSDK/Corepodspec.IMHO this should be done with the rest of the dependencies, what do you think?