Skip to content

Move view metadata (including view type) outside the configuration panel#508

Merged
conservationtimothy merged 3 commits into
mainfrom
feat/view-metadata-block
Jul 16, 2026
Merged

Move view metadata (including view type) outside the configuration panel#508
conservationtimothy merged 3 commits into
mainfrom
feat/view-metadata-block

Conversation

@conservationtimothy

Copy link
Copy Markdown
Contributor

Goal

Make immutable view identity (type, name, primary/secondary datasets) visible as read-only page metadata on /config/[dataset], instead of burying view type inside a collapsible “Views” section that looks configurable. Closes #501

Screenshots

Screenshot 2026-07-12 at 22 36 49 Screenshot 2026-07-12 at 22 36 39

What I changed and why

  • Moved view type out of the editable ConfigCard form and into a read-only metadata block under the page header, making it clear that view type is fixed after creation
  • Metadata block displays view type (icon + localized label), display name (viewName), primary dataset, and secondary dataset (or "None")
  • Name and description remain editable inside ConfigCard as before; the metadata block only mirrors saved identity fields and refreshes the display name after a successful save
  • Deleted ConfigViews.vue since the Views collapsible section is no longer needed
  • Updated e2e expectations to assert the header metadata block instead of the Views collapsible
  • Added i18n keys for the new metadata labels across all six locales

How I convinced myself this is right

The page already had the resolved view row (including viewName and secondaryDataset); the metadata block reads those values and keeps the same config-view-type-display test id so the type badge stays findable.

What I'm not doing here

LLM use disclosure

Cursor Grok 4.5 helped with translations

@rudokemper

Copy link
Copy Markdown
Member

Thanks @conservationtimothy, before doing code review I checked out the UI in development and had some thoughts:

image

(1) can be the Dataset Display Name (e.g. "BCM Form Responses - Gallery" in this example) instead of the primary dataset repeated
(2) In that case, we don't need this "Name" metadata field
(3) Instead of repeating the primary dataset here, can we provide a friendly name like "Configuration Options" (localized)?
(4) Kind-of out of scope, but I wouldn't mind you fixing this here: Can the copy instead say "Copy Config from Another View"

Lastly, can the page title be GuardianConnector Explorer: Configuration - {dataset_name} instead of GuardianConnector Explorer: Configuration - {primary-dataset}?

@conservationtimothy

conservationtimothy commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@rudokemper , sure ! But hold off on code review till I've implemented your suggestions.

On 1 and 5: Yes but will fallback to primary dataset if no display name has been configured.

Everything else i agree with.

@rudokemper rudokemper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I think there is a lot of unnecessary spacing between these 3 metadata items.

Can it be 3 cols that collapse responsively, and also not so much space between them?

@conservationtimothy

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-07-16 at 17 03 35 Screenshot 2026-07-16 at 17 04 00

@rudokemper Done

@conservationtimothy
conservationtimothy merged commit 9c45330 into main Jul 16, 2026
3 of 4 checks passed
@conservationtimothy
conservationtimothy deleted the feat/view-metadata-block branch July 16, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move view metadata (including view type) outside the configuration panel

2 participants