Fix CI: work around tox-docker Gateway KeyError on newer Docker#243
Merged
Conversation
IamJeffG
approved these changes
Jun 9, 2026
| PIP_UPLOADED_PRIOR_TO: P7D | ||
| # Skip tox-docker's NetworkSettings.Gateway lookup (broken on newer | ||
| # Docker in ubuntu-2404:current). machine-executor reaches containers | ||
| # via localhost anyway. |
Contributor
There was a problem hiding this comment.
would you mind labeling this as a temp workaround until tox-dev/tox-docker#196 is released?
(if you agree that's true)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Closes #242. Unblock
alertstox env on CI.This was not a Python / pip version issue as initially suspected, but rather a discrepancy between
tox-dockerandubuntu-2404:current.What I changed and why
We set
TOX_DOCKER_GATEWAY: localhostin.circleci/config.yml.Newer Docker on
ubuntu-2404:currentno longer fills top-levelNetworkSettings.Gateway, so tox-docker seems to crash with a KeyError. Claude Opus 4.7 did this diagnosis:How I convinced myself this is right
pip freezeis identical to previous green runs on CircleCI.alertstests seems to be passing again in CI.What I'm not doing here
ubuntu-2404to a dated tag.LLM use disclosure
Claude Opus 4.7 helped diagnose.