Skip to content

Conversation

@ValManP
Copy link
Contributor

@ValManP ValManP commented Aug 15, 2025

Description

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

@snyk-io
Copy link

snyk-io bot commented Aug 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@snyk-io
Copy link

snyk-io bot commented Aug 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

code/snyk check is complete. No issues have been found. (View Details)

@ValManP
Copy link
Contributor Author

ValManP commented Aug 15, 2025

@mga-chka could you please take a look?

Copy link
Contributor

@hileef hileef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ValManP , thank you for your contribution.
I would like to fast track this PR.

The tests are now allowed to proceed, could you check them and fix them as well please ? 🙂
If you can also add one that uses client_protocol_version=54460 as part of the cache key, even better 🙏

@ValManP
Copy link
Contributor Author

ValManP commented Aug 24, 2025

Hello @hileef, thank you for your review

I fixed the failing tests and added a new one for client_protocol_version. Please, take a look

Copy link
Contributor

@hileef hileef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again 🙂

@hileef hileef merged commit cad3e77 into ContentSquare:master Aug 24, 2025
8 checks passed
@r--w
Copy link

r--w commented Aug 25, 2025

Thank you for this PR, it solved our problem as well. 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants