-
Notifications
You must be signed in to change notification settings - Fork 272
[Feature] support client_protocol_version #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] support client_protocol_version #553
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
|
@mga-chka could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ValManP , thank you for your contribution.
I would like to fast track this PR.
The tests are now allowed to proceed, could you check them and fix them as well please ? 🙂
If you can also add one that uses client_protocol_version=54460 as part of the cache key, even better 🙏
|
Hello @hileef, thank you for your review I fixed the failing tests and added a new one for |
hileef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again 🙂
|
Thank you for this PR, it solved our problem as well. 🥇 |
Description
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
Further comments