feat: cache: redis: tls: allow enabling without client certs #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
render
bot
temporarily deployed
to
feat/cache/redis/support-conn-tls-public-server-only - chproxy PR #556
hileef
force-pushed
the
feat/cache/redis/support-conn-tls-public-server-only
branch
from
417179e to
7a8a4d9
Compare
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
🎉 Snyk checks have passed. No issues have been found so far.✅ code/snyk check is complete. No issues have been found. (View Details) |
hileef
force-pushed
the
feat/cache/redis/support-conn-tls-public-server-only
branch
from
7a8a4d9 to
85c7f94
Compare
render
bot
temporarily deployed
to
feat/cache/redis/support-conn-tls-public-server-only - chproxy PR #556
alifirat
approved these changes
Sep 10, 2025
|
|
||
| if len(cfg.CertFile) != 0 || len(cfg.KeyFile) != 0 { | ||
| // maintain backwards compatibility in case of non-presence of enable_tls | ||
| if len(cfg.CertFile) != 0 || len(cfg.KeyFile) != 0 || cfg.EnableTLS { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow enabling TLS on the connection to redis cache without specifying a client-side certificate & key pair.
This should fix #550 , but requires specifying
enable_tls: truein the configuration.Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?